Snapshotting.formattedData: use JSONEncoder.OutputFormatting.withoutEscapingSlashes if available#1560
Merged
Merged
Conversation
Contributor
Author
|
This will make tests fail, but it'll be a good way to test @joshdholtz's future PR to generate snapshots :) (though we first should fix iOS 12 tests in |
e9ff24d to
aba53d6
Compare
aba53d6 to
9f4f7d5
Compare
Member
|
what's the status of this one? Is it blocked by #1561? |
Contributor
Author
|
I can manually update the snapshots, but it's a perfect test case for #1561 yeah. |
9f4f7d5 to
496c129
Compare
aboedo
approved these changes
May 26, 2022
…utEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
496c129 to
132b763
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed after a PR review comment because it would have lead to different snapshots in iOS 12.
However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible.
Example: