Backend snapshot tests: separate snapshot for each major version#1504
Merged
Conversation
NachoSoto
commented
Apr 13, 2022
Comment on lines
33
to
52
Contributor
Author
There was a problem hiding this comment.
This is the core of this PR. Thanks @taquitos for the idea.
taquitos
suggested changes
Apr 13, 2022
taquitos
left a comment
Contributor
There was a problem hiding this comment.
Awesome stuff, one possible change I see some files prefixed like iOSiOS15
Contributor
Author
|
Oops good catch! I forgot we have those separate tests as well. |
Contributor
Author
|
Combined |
taquitos
reviewed
Apr 13, 2022
Contributor
There was a problem hiding this comment.
BackendPostReceiptDataTest -> BackendPostReceiptDataTests
taquitos
approved these changes
Apr 13, 2022
taquitos
left a comment
Contributor
There was a problem hiding this comment.
The smallest comment update, but then 🚢
Contributor
Author
|
I'll wait to merge this until somebody can generate the iOS 12 snapshots for me 🙏🏻 |
Contributor
updating my Intel mac 🙃 |
Fixes [CF-547]. This also removes the duplicate `BackendPostRecepitDataTests` for each version, as only 1 is needed now. `assertSnapshot` encodes the version in the filename.
5fff36d to
8d8cec1
Compare
Contributor
|
@NachoSoto this is ready when you are 😄 |
Contributor
Author
|
Awesome thanks! Just pushed the comment fix, I'll merge this and make sure they're passing in |
NachoSoto
added a commit
that referenced
this pull request
May 10, 2022
…utEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
NachoSoto
added a commit
that referenced
this pull request
May 20, 2022
…utEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
NachoSoto
added a commit
that referenced
this pull request
May 25, 2022
…utEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
NachoSoto
added a commit
that referenced
this pull request
Jun 9, 2022
…utEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
NachoSoto
added a commit
that referenced
this pull request
Jun 9, 2022
…utEscapingSlashes` if available (#1560) This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ```
joshdholtz
pushed a commit
that referenced
this pull request
May 12, 2023
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/6737/workflows/b945f5f6-6f31-4716-b1ac-6e16e3848c7e/jobs/26321 For some reason, on iOS 12.x only, this: ```swift JSONDecoder.default.decode(jsonData: "null".data(using: .utf8)!) ``` Fails: ``` dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}))) ``` We don't rely on decoding fragments, so I just updated the test to check `.null` within a dictionary instead. `Snapshotting.formattedData`: use `JSONEncoder.OutputFormatting.withoutEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ``` Update CircleCI config to use pipeline parameters to set generate snapshots env Run all in one serially Split OS version into their own jobs Create PR from all os version jobs This is the one Added requestby user in body Fix for pr actually creating Reordered some things Remove tvos from generated jobs Raw output when generating snapshots Don't retry tests when generating snapshots Maybe this will make the PRs Maybe this This is it
joshdholtz
pushed a commit
that referenced
this pull request
May 12, 2023
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/6737/workflows/b945f5f6-6f31-4716-b1ac-6e16e3848c7e/jobs/26321 For some reason, on iOS 12.x only, this: ```swift JSONDecoder.default.decode(jsonData: "null".data(using: .utf8)!) ``` Fails: ``` dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}))) ``` We don't rely on decoding fragments, so I just updated the test to check `.null` within a dictionary instead. `Snapshotting.formattedData`: use `JSONEncoder.OutputFormatting.withoutEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ``` Update CircleCI config to use pipeline parameters to set generate snapshots env Run all in one serially Split OS version into their own jobs Create PR from all os version jobs This is the one Added requestby user in body Fix for pr actually creating Reordered some things Remove tvos from generated jobs Raw output when generating snapshots Don't retry tests when generating snapshots Maybe this will make the PRs Maybe this This is it
joshdholtz
pushed a commit
that referenced
this pull request
May 12, 2023
Fixes https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/6737/workflows/b945f5f6-6f31-4716-b1ac-6e16e3848c7e/jobs/26321 For some reason, on iOS 12.x only, this: ```swift JSONDecoder.default.decode(jsonData: "null".data(using: .utf8)!) ``` Fails: ``` dataCorrupted(Swift.DecodingError.Context(codingPath: [], debugDescription: "The given data was not valid JSON.", underlyingError: Optional(Error Domain=NSCocoaErrorDomain Code=3840 "JSON text did not start with array or object and option to allow fragments not set." UserInfo={NSDebugDescription=JSON text did not start with array or object and option to allow fragments not set.}))) ``` We don't rely on decoding fragments, so I just updated the test to check `.null` within a dictionary instead. `Snapshotting.formattedData`: use `JSONEncoder.OutputFormatting.withoutEscapingSlashes` if available This was removed after a [PR review comment](#1366 (comment)) because it would have lead to different snapshots in iOS 12. However, since #1504 we have separate snapshots for each iOS version, so this cleans up the output when possible. ```diff - "url" : "https:\/\/api.revenuecat.com\/v1\/subscribers\/user\/alias" + "url" : "https://api.revenuecat.com/v1/subscribers/user/alias" ``` Update CircleCI config to use pipeline parameters to set generate snapshots env Run all in one serially Split OS version into their own jobs Create PR from all os version jobs This is the one Added requestby user in body Fix for pr actually creating Reordered some things Remove tvos from generated jobs Raw output when generating snapshots Don't retry tests when generating snapshots Maybe this will make the PRs Maybe this This is it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CF-547.
I recommend reviewing this ignoring JSON files:https://github.com/RevenueCat/purchases-ios/pull/1504/files?file-filters%5B%5D=.pbxproj&file-filters%5B%5D=.swift&show-deleted-files=true&show-viewed-files=true
This also combines the duplicate copies of some tests for each version, as only 1 is needed now.
assertSnapshotencodes the version in the filename.Combined:
BackendPostRecepitDataTestsBackendSubscriberAttributesTestsNo more unnecessary skipped tests.
Number of tests skipped | 112Number of tests skipped | 58Example:
Because iOS 12.x simulators currently crash on M1 Macs, I haven't generated those snapshots yet.