Extract Attribution logic out of Purchases by taquitos · Pull Request #1693 · RevenueCat/purchases-ios

taquitos · 2022-06-11T00:12:37Z

Move all Purchases.setX attribution-related things into their own namespace Purchases.Attribution.setX
We can deprecate the current ones and easily have Xcode fixes for them all when we release RCv5 (whenever that is)
I think extracting API from Purchases into Purchases. makes a lot of sense and is more discoverable/friendly for docs, too.

Resolves CSDK-128

aboedo

absolutely love it so far. We should get the API testers updated as well

aboedo · 2022-06-13T12:18:54Z

👏 👏 👏 👏

NachoSoto

Just a few issues with API testers, but I love this refactor.

NachoSoto · 2022-06-14T16:53:24Z

Awesome.
These probably create a bunch new deprecation warnings when compiling SwiftAPITester.
Could you add an annotation to checkPurchasesSubscriberAttributesAPI like I did in #1631?

Ohhhh good idea.

NachoSoto · 2022-06-14T16:53:58Z

Suggested change

* Attribution object that is responsible for all explicit attribution APIs

* ``Attribution`` object that is responsible for all explicit attribution APIs

NachoSoto · 2022-06-14T16:54:21Z

What do you mean by this?

Oooh I think you meant

Suggested change

* - Note: Calling this static property or to instance property has the same effect.

* - Note: Calling this static property or the instance property has the same effect.

I wonder if we actually need this static one though. I'm usually not a big fan of offering two ways of doing the same thing, leads to users potentially wondering "what's the difference?", and IMO it doesn't add much.

And considering that this one implicitly relies on the SDK being already configured, I think that can be made explicit by forcing users to call it on Purchases.shared.

Cool, I was leaning towards removing it, so I'm glad you agree 😄

NachoSoto · 2022-06-14T16:56:04Z

Suggested change

* Attribution object that is responsible for all explicit attribution APIs

* ``Attribution`` object that is responsible for all explicit attribution APIs

NachoSoto · 2022-06-14T16:56:57Z

Wait, but these methods STILL need to be available because they're deprecated and not obsoleted, so we should check that they're still available by leaving this as is.

You can add

@available(*, deprecated) // Ignore deprecation warnings

To silence the warnings

NachoSoto · 2022-06-14T16:59:27Z

This is missing

RCAttribution *attribution = [p attribution];

NachoSoto · 2022-06-14T16:59:55Z

All these are already checked by RCAttributionAPI, so I'd remove them?

NachoSoto · 2022-06-14T17:00:39Z

This file is just missing:

let attribution: Attribution = purchases.attribution

Add deprecations

NachoSoto · 2022-06-14T21:11:42Z


+@available(*, deprecated) // Ignore deprecation warnings
 private func checkPurchasesSubscriberAttributesAPI(purchases: Purchases) {
+    _ = purchases.attribution


This needs to check the type:

Suggested change

_ = purchases.attribution

let _: Attribution = purchases.attribution

And I would move this out of this method since it's not deprecated (and if it were, we wouldn't want to ignore that warning)

Move purchases.attribution from deprecation section to current api

joshdholtz · 2022-06-14T21:23:22Z

@beylmk Mentioning you here because I think we will want to rework the AdServices public API into what is going on in this PR? 🤷‍♂️

See #1693.

See RevenueCat/purchases-ios#1693

@NachoSoto

### Changes: * Replaced `CustomerInfo.nonSubscriptionTransactions` with a new non-`StoreTransaction` type (#1733) via NachoSoto (@NachoSoto) * `Purchases.configure`: added overload taking a `Configuration.Builder` (#1720) via NachoSoto (@NachoSoto) * Extract Attribution logic out of Purchases (#1693) via Joshua Liebowitz (@taquitos) * Remove create alias (#1695) via Joshua Liebowitz (@taquitos) All attribution APIs can now be accessed from `Purchases.shared.attribution`. ### Improvements: * Improved purchasing logs, added promotional offer information (#1725) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: don't log attribute errors if there are none (#1742) via NachoSoto (@NachoSoto) * `FatalErrorUtil`: don't override `fatalError` on release builds (#1736) via NachoSoto (@NachoSoto) * `SKPaymentTransaction`: added more context to warnings about missing properties (#1731) via NachoSoto (@NachoSoto) * New SwiftUI Purchase Tester example (#1722) via Josh Holtz (@joshdholtz) * update docs for `showManageSubscriptions` (#1729) via aboedo (@aboedo) * `PurchasesOrchestrator`: unify finish transactions between SK1 and SK2 (#1704) via NachoSoto (@NachoSoto) * `SubscriberAttribute`: converted into `struct` (#1648) via NachoSoto (@NachoSoto) * `CacheFetchPolicy.notStaleCachedOrFetched`: added warning to docstring (#1708) via NachoSoto (@NachoSoto) * Clear cached offerings and products after Storefront changes (2/4) (#1583) via Juanpe Catalán (@Juanpe) * `ROT13`: optimized initialization and removed magic numbers (#1702) via NachoSoto (@NachoSoto) ### Fixes: * `logIn`/`logOut`: sync attributes before aliasing (#1716) via NachoSoto (@NachoSoto) * `Purchases.customerInfo(fetchPolicy:)`: actually use `fetchPolicy` parameter (#1721) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: fix behavior dealing with `nil` `SKPaymentTransaction.productIdentifier` during purchase (#1680) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator.handlePurchasedTransaction`: always refresh receipt data (#1703) via NachoSoto (@NachoSoto)

See RevenueCat/purchases-ios#1693

taquitos requested a review from a team June 11, 2022 00:12

aboedo reviewed Jun 13, 2022

View reviewed changes

NachoSoto suggested changes Jun 14, 2022

View reviewed changes

Joshua Liebowitz added 6 commits June 14, 2022 13:44

Proof of concept

9d178eb

This compiles, right?

bc864a1

Update attribution namespacing in tests and tester

730e92e

Add deprecations

Update APITesters

7df143a

Update for comments

7cc23b2

Update for comments

01b691a

taquitos force-pushed the attributes branch from 5727558 to 01b691a Compare June 14, 2022 21:10

NachoSoto approved these changes Jun 14, 2022

View reviewed changes

Update PurchasesAPI.swift

ca97185

Move purchases.attribution from deprecation section to current api

taquitos merged commit 29f96df into main Jun 14, 2022

taquitos deleted the attributes branch June 14, 2022 21:37

NachoSoto added a commit that referenced this pull request Jun 19, 2022

Integration tests: fixed deprecation warnings

26097fb

See #1693.

NachoSoto mentioned this pull request Jun 19, 2022

Integration tests: fixed deprecation warnings #1713

Merged

NachoSoto added a commit that referenced this pull request Jun 21, 2022

Integration tests: fixed deprecation warnings (#1713)

10776ff

See #1693.

joshdholtz mentioned this pull request Jun 22, 2022

AdServices #1727

Merged

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jun 23, 2022

Fixed Attribution deprecation warnings

6f40688

See RevenueCat/purchases-ios#1693

This was referenced Jun 23, 2022

Fixed Attribution deprecation warnings RevenueCat/purchases-hybrid-common#150

Closed

Release/4.7.0 #1745

Merged

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jul 4, 2022

Fixed Attribution deprecation warnings

cef92b7

See RevenueCat/purchases-ios#1693

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jul 4, 2022

Fixed Attribution deprecation warnings

f9e3fbf

See RevenueCat/purchases-ios#1693

NachoSoto added a commit to RevenueCat/purchases-hybrid-common that referenced this pull request Jul 4, 2022

Fixed Attribution deprecation warnings

06adfc3

See RevenueCat/purchases-ios#1693

	* Attribution object that is responsible for all explicit attribution APIs
	* ``Attribution`` object that is responsible for all explicit attribution APIs

	* - Note: Calling this static property or to instance property has the same effect.
	* - Note: Calling this static property or the instance property has the same effect.

	_ = purchases.attribution
	let _: Attribution = purchases.attribution

Conversation

taquitos commented Jun 11, 2022 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aboedo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NachoSoto left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joshdholtz commented Jun 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

taquitos commented Jun 11, 2022 •

edited by atlassian Bot

Loading