PurchasesOrchestrator: unify finish transactions between SK1 and SK2#1704
Merged
Conversation
NachoSoto
commented
Jun 14, 2022
PurchasesOrchestrator: unify finish transactions between SK1 and SK2PurchasesOrchestrator: unify finish transactions between SK1 and SK2
7b0ac51 to
f2a7dd2
Compare
Base automatically changed from
purchases-orchestrator-always-when-purchasing
to
main
June 16, 2022 16:09
69b2209 to
4b976f8
Compare
PurchasesOrchestrator: unify finish transactions between SK1 and SK2PurchasesOrchestrator: unify finish transactions between SK1 and SK2
NachoSoto
commented
Jun 21, 2022
Comment on lines
57
to
59
Contributor
Author
There was a problem hiding this comment.
Another clue that BackendParsedTransaction shouldn't be a StoreTransactionType.
Contributor
Author
There was a problem hiding this comment.
I'm worried that we might not be able to fix this, because CustomerInfo.nonSubscriptionTransactions returns [StoreTransaction].
Member
There was a problem hiding this comment.
we'll have to create a new property, deprecate this one, and wait until the next major for a full fix I think.
Contributor
Author
There was a problem hiding this comment.
I thought there was a Jira for it, do you remember if there's one? I'll create it if not.
Member
There was a problem hiding this comment.
I don't recall a jira task for it, feel free to create one
Contributor
Author
|
@aboedo okay I've updated this :) |
Fixes [CSDK-122]. Before this change, transactions were finished separately for SK1 and SK2. Now this is combined through a common method in `StoreTransactionType`.
4b976f8 to
91a750f
Compare
aboedo
approved these changes
Jun 21, 2022
Comment on lines
57
to
59
Member
There was a problem hiding this comment.
we'll have to create a new property, deprecate this one, and wait until the next major for a full fix I think.
Merged
NachoSoto
added a commit
that referenced
this pull request
Jul 4, 2022
### Changes: * Replaced `CustomerInfo.nonSubscriptionTransactions` with a new non-`StoreTransaction` type (#1733) via NachoSoto (@NachoSoto) * `Purchases.configure`: added overload taking a `Configuration.Builder` (#1720) via NachoSoto (@NachoSoto) * Extract Attribution logic out of Purchases (#1693) via Joshua Liebowitz (@taquitos) * Remove create alias (#1695) via Joshua Liebowitz (@taquitos) All attribution APIs can now be accessed from `Purchases.shared.attribution`. ### Improvements: * Improved purchasing logs, added promotional offer information (#1725) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: don't log attribute errors if there are none (#1742) via NachoSoto (@NachoSoto) * `FatalErrorUtil`: don't override `fatalError` on release builds (#1736) via NachoSoto (@NachoSoto) * `SKPaymentTransaction`: added more context to warnings about missing properties (#1731) via NachoSoto (@NachoSoto) * New SwiftUI Purchase Tester example (#1722) via Josh Holtz (@joshdholtz) * update docs for `showManageSubscriptions` (#1729) via aboedo (@aboedo) * `PurchasesOrchestrator`: unify finish transactions between SK1 and SK2 (#1704) via NachoSoto (@NachoSoto) * `SubscriberAttribute`: converted into `struct` (#1648) via NachoSoto (@NachoSoto) * `CacheFetchPolicy.notStaleCachedOrFetched`: added warning to docstring (#1708) via NachoSoto (@NachoSoto) * Clear cached offerings and products after Storefront changes (2/4) (#1583) via Juanpe Catalán (@Juanpe) * `ROT13`: optimized initialization and removed magic numbers (#1702) via NachoSoto (@NachoSoto) ### Fixes: * `logIn`/`logOut`: sync attributes before aliasing (#1716) via NachoSoto (@NachoSoto) * `Purchases.customerInfo(fetchPolicy:)`: actually use `fetchPolicy` parameter (#1721) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: fix behavior dealing with `nil` `SKPaymentTransaction.productIdentifier` during purchase (#1680) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator.handlePurchasedTransaction`: always refresh receipt data (#1703) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CSDK-122.
Before this change, transactions were finished separately for SK1 and SK2. Now this is combined through a common method in
StoreTransactionType.