Removed all deprecation warnings in tests / SwiftAPITester#1631
Merged
Conversation
NachoSoto
added a commit
that referenced
this pull request
May 31, 2022
Now that #1631 fixed all warnings (plus a few more fixed here that I missed), we can enforce this to make sure we don't add any more in the future.
NachoSoto
added a commit
that referenced
this pull request
Jun 2, 2022
Now that #1631 fixed all warnings (plus a few more fixed here that I missed), we can enforce this to make sure we don't add any more in the future. Note that `StoreKitUnitTests` and `BackendIntegrationTests` override the flag to disable it because currently `SKAdTestSession` has a warning: ``` /Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/StoreKitTest.h:10:9: note: in file included from /Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/StoreKitTest.h:10: #import <StoreKitTest/SKAdTestSession.h> ^ /Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/SKAdTestSession.h:22:1: error: conflicting nullability specifier on return types, 'nullable' conflicts with existing specifier 'nonnull' - (nullable instancetype)init; ^ /Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/usr/include/objc/NSObject.h:63:1: note: previous declaration is here - (instancetype)init ^ ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project now builds with no warnings 🎉