Skip to content

Treat warnings as errors#1635

Merged
NachoSoto merged 1 commit into
mainfrom
warnings-as-errors
Jun 2, 2022
Merged

Treat warnings as errors#1635
NachoSoto merged 1 commit into
mainfrom
warnings-as-errors

Conversation

@NachoSoto

@NachoSoto NachoSoto commented May 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Now that #1631 fixed all warnings (plus a few more fixed here that I missed), we can enforce this to make sure we don't add any more in the future.

Note that StoreKitUnitTests and BackendIntegrationTests override the flag to disable it because currently SKAdTestSession has a warning:

/Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/StoreKitTest.h:10:9: note: in file included from /Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/StoreKitTest.h:10:
#import <StoreKitTest/SKAdTestSession.h>
        ^
/Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/Developer/Library/Frameworks/StoreKitTest.framework/Headers/SKAdTestSession.h:22:1: error: conflicting nullability specifier on return types, 'nullable' conflicts with existing specifier 'nonnull'
- (nullable instancetype)init;
^
/Applications/Xcode-13.4.0-Release.Candidate.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator15.5.sdk/usr/include/objc/NSObject.h:63:1: note: previous declaration is here
- (instancetype)init
^

@NachoSoto NachoSoto requested a review from a team May 31, 2022 20:29
@NachoSoto NachoSoto force-pushed the warnings-as-errors branch from f8b2b23 to 0bf1e88 Compare May 31, 2022 20:38
@NachoSoto
Treat warnings as errors
a1d4647 
Now that #1631 fixed all warnings (plus a few more fixed here that I missed), we can enforce this to make sure we don't add any more in the future.
@NachoSoto NachoSoto force-pushed the warnings-as-errors branch from 0bf1e88 to a1d4647 Compare May 31, 2022 21:11
@taquitos

taquitos commented May 31, 2022

Copy link
Copy Markdown
Contributor

I cancelled the iOS 15 tests, it was taking over 2 hours 🙀

@NachoSoto

NachoSoto commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

They're passing now :)

taquitos
taquitos approved these changes Jun 1, 2022
View reviewed changes

@taquitos taquitos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌶️ 🐐

@NachoSoto NachoSoto merged commit a64480e into main Jun 2, 2022
@NachoSoto NachoSoto deleted the warnings-as-errors branch June 2, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@taquitos taquitos taquitos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NachoSoto @taquitos