CodableStrings.decoding_error: added underlying error information#1668
Merged
Conversation
While debugging `CustomerInfo` decoding errors for example, this is the existing error logged in the console: ``` ERROR: 😿‼️ Couldn't decode data from json. Error: There was a problem related to the customer info. ``` With this change: ``` ERROR: 😿‼️ Couldn't decode data from json. Error: There was a problem related to the customer info.. Underlying error: Swift.DecodingError.typeMismatch(Swift.Dictionary<Swift.String, RevenueCat.CustomerInfoResponse.Subscription>, Swift.DecodingError.Context(codingPath: [CodingKeys(stringValue: "subscriber", intValue: nil), CodingKeys(stringValue: "subscriptions", intValue: nil)], debugDescription: "Expected to decode Dictionary<String, Subscription> but found an array instead.", underlyingError: nil)) ```
Contributor
Author
|
Flaky tests. |
Contributor
I think cleaning up any data that could persist between launches makes sense. It's a bummer this doesn't happen all the time, but I'm not shocked. |
Contributor
Author
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 7, 2022
_This version supports Xcode 14 beta 1_ * `PurchasesOrchestrator.handleDeferredTransaction`: check `NSError.domain` too (#1665) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: replaced manual `Lock` with `Atomic` (#1664) via NachoSoto (@NachoSoto) * `CodableStrings.decoding_error`: added underlying error information (#1668) via NachoSoto (@NachoSoto) * Fixed Xcode 14 compilation: avoid `@available` properties (#1661) via NachoSoto (@NachoSoto)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging
CustomerInfodecoding errors for example, this is the existing error logged in the console:With this change: