Fixed Xcode 14 compilation: avoid @available properties#1661
Merged
Conversation
taquitos
reviewed
Jun 6, 2022
| @available(watchOS, unavailable) | ||
| @available(tvOS, unavailable) | ||
| lazy var sk2Helper = SK2BeginRefundRequestHelper() | ||
| var sk2Helper: SK2BeginRefundRequestHelper { |
Contributor
Author
|
The |
Contributor
Author
|
Okay this is ready now. |
Member
|
awesome! should we prepare a release for it? |
5 tasks
Contributor
Author
|
I'm not against it, but we might have to make one release for every beta. |
Contributor
|
I think since this makes it compile in Xcode 14, we should do a release, it could be blocking customers from testing 😄 |
Contributor
Author
|
Since they're building with a beta version of Xcode anyway and can't even be released, they could point to |
Contributor
|
Yeah, I'm just thinking about how we can cut down any further noise to support. |
Contributor
Author
|
That's fair. Okay I can do a |
Contributor
Author
|
But let me see if I can wrap up #1666, it would be nice to include too. |
5 tasks
Merged
NachoSoto
added a commit
that referenced
this pull request
Jun 7, 2022
_This version supports Xcode 14 beta 1_ * `PurchasesOrchestrator.handleDeferredTransaction`: check `NSError.domain` too (#1665) via NachoSoto (@NachoSoto) * `PurchasesOrchestrator`: replaced manual `Lock` with `Atomic` (#1664) via NachoSoto (@NachoSoto) * `CodableStrings.decoding_error`: added underlying error information (#1668) via NachoSoto (@NachoSoto) * Fixed Xcode 14 compilation: avoid `@available` properties (#1661) via NachoSoto (@NachoSoto)
NachoSoto
added a commit
that referenced
this pull request
Jun 14, 2022
Equivalent to #1661 but for tests.
NachoSoto
added a commit
that referenced
this pull request
Jun 14, 2022
Equivalent to #1661 but for tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660 and SDKONCALL-24.
This is the same approach used in #1596.