Integration Tests: always clear Bundle.appStoreReceiptURL before every test#1671
Merged
Conversation
…every test I've noticed sometimes tests start with some receipts that are pending to submit, which could lead to flaky tests. Hopefully this makes them less flaky.
c9db53a to
fd6e9a1
Compare
Contributor
Author
|
cc @aboedo |
NachoSoto
added a commit
that referenced
this pull request
Jun 14, 2022
…ery test Equivalent to #1671 but for unit tests. In iOS 16 (as of beta 1), the receipt persists across tests, despite the use of `SKTestSession.resetToDefaultState`. This might also help with flaky tests pre-iOS 16 too. Also note that I fixed this method in `BaseBackendIntegrationTests`. Using `URL.absoluteString` was incorrect there, so the file was probably never deleted.
NachoSoto
added a commit
that referenced
this pull request
Jun 14, 2022
…ery test Equivalent to #1671 but for unit tests. In iOS 16 (as of beta 1), the receipt persists across tests, despite the use of `SKTestSession.resetToDefaultState`. This might also help with flaky tests pre-iOS 16 too. Also note that I fixed this method in `BaseBackendIntegrationTests`. Using `URL.absoluteString` was incorrect there, so the file was probably never deleted.
NachoSoto
added a commit
that referenced
this pull request
Jun 14, 2022
…ery test (#1700) Equivalent to #1671 but for unit tests. In iOS 16 (as of beta 1), the receipt persists across tests, despite the use of `SKTestSession.resetToDefaultState`. This might also help with flaky tests pre-iOS 16 too. Also note that I fixed this method in `BaseBackendIntegrationTests`. Using `URL.absoluteString` was incorrect there, so the file was probably never deleted. I filed a feedback (FB10252944) for this: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed sometimes tests start with some receipts that are pending to submit, which could lead to flaky tests.
Hopefully this makes them less flaky.