Skip to content

[External] Fix PurchasesIntegrationTest building issue#996

Merged
vegaro merged 1 commit into
RevenueCat:merge-external-pablo-guardiola-pg-fix-purchases-android-integration-testsfrom
pablo-guardiola:pg-fix-purchases-android-integration-tests
May 4, 2023
Merged

[External] Fix PurchasesIntegrationTest building issue#996
vegaro merged 1 commit into
RevenueCat:merge-external-pablo-guardiola-pg-fix-purchases-android-integration-testsfrom
pablo-guardiola:pg-fix-purchases-android-integration-tests

Conversation

@pablo-guardiola

Copy link
Copy Markdown
Contributor

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-ios and hybrids

Motivation

Why is this change required? What problem does it solve?

CI run-firebase-tests-purchases-load-shedder-integration-test job in main is currently ❌ https://app.circleci.com/pipelines/github/RevenueCat/purchases-android/5569/workflows/a55166e6-0930-4086-ad32-5328d0a109d8/jobs/15888

> Task :purchases:compileIntegrationTestReleaseAndroidTestKotlin
e: /home/circleci/project/purchases/src/androidTestIntegrationTest/kotlin/com/revenuecat/purchases/factories/StoreTransactionFactory.kt: (43, 9): No value passed for parameter 'prorationMode'

Regression from #977

Description

Describe your changes in detail

  • Add default ProrationMode (null) to StoreTransactionFactory#createStoreTransaction

Please describe in detail how you tested your changes

  • Run PurchasesIntegrationTest before the changes ❌
  • Run PurchasesIntegrationTest after the changes ✅

cc @swehner

…onMode in StoreTransactionFactory#createStoreTransaction - regression from RevenueCat#977
@pablo-guardiola pablo-guardiola force-pushed the pg-fix-purchases-android-integration-tests branch from d2a2c5d to 0f271b1 Compare May 4, 2023 21:42
@pablo-guardiola

Copy link
Copy Markdown
Contributor Author

@vegaro another quick fix if you're still around. I'll rebase as soon as #995 is merged.

@vegaro vegaro changed the base branch from main to merge-external-pablo-guardiola-pg-fix-purchases-android-integration-tests May 4, 2023 23:50
@vegaro vegaro merged this pull request into RevenueCat:merge-external-pablo-guardiola-pg-fix-purchases-android-integration-tests May 4, 2023
@vegaro vegaro changed the title Fix PurchasesIntegrationTest building issue [External] Fix PurchasesIntegrationTest building issue May 4, 2023
vegaro pushed a commit that referenced this pull request May 6, 2023
vegaro added a commit that referenced this pull request May 11, 2023
Co-authored-by: pablo-guardiola <131195486+pablo-guardiola@users.noreply.github.com>
tonidero added a commit that referenced this pull request May 18, 2023
**This is an automatic release.**

### New Features
* CAT-859 Expose whether or not a SubscriptionOption is Prepaid in the
SDK (#1005) via Deema AlShamaa (@dalshamaa)
### Bugfixes
* [CF-1324] Fix personalizedPrice defaulting to false (#952) via beylmk
(@beylmk)
### Performance Improvements
* Store and return ETag last refresh time header (#978) via Toni Rico
(@tonidero)
### Dependency Updates
* Bump fastlane-plugin-revenuecat_internal from `3b03efa` to `fe45299`
(#991) via dependabot[bot] (@dependabot[bot])
* Bump danger from 9.2.0 to 9.3.0 (#981) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `8482a43` to `3b03efa`
(#974) via dependabot[bot] (@dependabot[bot])
* Bump fastlane from 2.212.1 to 2.212.2 (#973) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `9255366` to `8482a43`
(#961) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Add proration modes to post to backend (#977) via swehner (@swehner)
* Added ENTITLEMENTS_COMPUTED_ON_DEVICE (#939) via Cesar de la Vega
(@vegaro)
* Fix flaky test in OfflineCustomerInfoCalculatorTest (#997) via Cesar
de la Vega (@vegaro)
* Fix `OfflineCustomerInfoCalculatorTest` `Unresolved reference:
ProducType` (#995) via Cesar de la Vega (@vegaro)
* Add support for product_plan_identifier for offline customer info
(#959) via Cesar de la Vega (@vegaro)
* Add non-subscriptions support to offline customer info (#958) via
Cesar de la Vega (@vegaro)
* Query only active purchases when generating offline entitlements
customer info (#1003) via Toni Rico (@tonidero)
* Fix `PurchasesIntegrationTest` building issue (#996 into main) (#998)
via Cesar de la Vega (@vegaro)
* Fail offline entitlements computation if product entitlement mapping
not available (#999) via Toni Rico (@tonidero)
* Fix  build_magic_weather lane (#993) via Cesar de la Vega (@vegaro)
* Add backend integration tests and test product entitlement mapping
endpoint (#988) via Toni Rico (@tonidero)
* Fix purchases integration tests (#980) via Toni Rico (@tonidero)
* Disable offline entitlements if active inapp purchases exist (#983)
via Toni Rico (@tonidero)
* Clear cached customer info upon entering offline entitlements mode
(#989) via Toni Rico (@tonidero)
* Update product entitlement mapping request to new format (#976) via
Toni Rico (@tonidero)
* Support enabling/disabling offline entitlements (#964) via Toni Rico
(@tonidero)
* Add back integration tests automation (#972) via Toni Rico (@tonidero)
* Upgrade to AGP 8.0 (#975) via Toni Rico (@tonidero)
* Extract post receipt logic to PostReceiptHelper (#967) via Toni Rico
(@tonidero)
* Add isServerDown to error callback for postReceipt and getCustomerInfo
requests (#963) via Toni Rico (@tonidero)
* Add back integration test flavors (#962) via Toni Rico (@tonidero)
* Fix storing test results (#966) via Cesar de la Vega (@vegaro)
* Extract detekt job from test job (#965) via Cesar de la Vega (@vegaro)


[CF-1324]:
https://revenuecats.atlassian.net/browse/CF-1324?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants