Upgrade to AGP 8.0#975
Conversation
| ext.compileVersion = 31 | ||
| ext.kotlinVersion = "1.6.21" | ||
| ext.purchasesVersion = "6.0.0-alpha.4" | ||
| ext.purchasesVersion = "6.1.1" |
There was a problem hiding this comment.
I don't know why we were pointing to the alpha version here but I was running into some issues so instead of trying to fix things in that version, I just updated to the latest (and had to do a couple of changes as a result)
| namespace 'com.revenuecat.purchases.common' | ||
|
|
||
| buildFeatures { | ||
| buildConfig true |
There was a problem hiding this comment.
We use the BuildConfig file in the common module to enable debug logs automatically on debug versions.
| buildFeatures { | ||
| buildConfig true | ||
| } | ||
| namespace 'com.revenuecat.sample' |
There was a problem hiding this comment.
Had to remove this from the AndroidManifest and into the build.gradle
| @@ -0,0 +1,2 @@ | |||
| -dontwarn com.google.errorprone.annotations.CanIgnoreReturnValue | |||
| -dontwarn com.google.errorprone.annotations.Immutable | |||
There was a problem hiding this comment.
Looks like the new R8 full mode is not compatible with the latest version of Tink-Android... Currently that library is unused until we actually finish Trusted entitlements. For now, I checked and these 2 annotations seem to only be used for internal checks of the library, so it should be safe to ignore them... In any case, I reported this in Tink-Java: tink-crypto/tink-java#7 so they can hopefully add the rules in the library itself.
vegaro
left a comment
There was a problem hiding this comment.
Looks like the changes are pretty safe. Don't know if you've teste it yet, but I would try a release to local maven though and see if the publishing plugin works as expected.
I had not tried it, good call! I just did and was able to publish correctly and tested the version from MagicWeather without issues 👍 |
**This is an automatic release.** ### New Features * CAT-859 Expose whether or not a SubscriptionOption is Prepaid in the SDK (#1005) via Deema AlShamaa (@dalshamaa) ### Bugfixes * [CF-1324] Fix personalizedPrice defaulting to false (#952) via beylmk (@beylmk) ### Performance Improvements * Store and return ETag last refresh time header (#978) via Toni Rico (@tonidero) ### Dependency Updates * Bump fastlane-plugin-revenuecat_internal from `3b03efa` to `fe45299` (#991) via dependabot[bot] (@dependabot[bot]) * Bump danger from 9.2.0 to 9.3.0 (#981) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `8482a43` to `3b03efa` (#974) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.212.1 to 2.212.2 (#973) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `9255366` to `8482a43` (#961) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Add proration modes to post to backend (#977) via swehner (@swehner) * Added ENTITLEMENTS_COMPUTED_ON_DEVICE (#939) via Cesar de la Vega (@vegaro) * Fix flaky test in OfflineCustomerInfoCalculatorTest (#997) via Cesar de la Vega (@vegaro) * Fix `OfflineCustomerInfoCalculatorTest` `Unresolved reference: ProducType` (#995) via Cesar de la Vega (@vegaro) * Add support for product_plan_identifier for offline customer info (#959) via Cesar de la Vega (@vegaro) * Add non-subscriptions support to offline customer info (#958) via Cesar de la Vega (@vegaro) * Query only active purchases when generating offline entitlements customer info (#1003) via Toni Rico (@tonidero) * Fix `PurchasesIntegrationTest` building issue (#996 into main) (#998) via Cesar de la Vega (@vegaro) * Fail offline entitlements computation if product entitlement mapping not available (#999) via Toni Rico (@tonidero) * Fix build_magic_weather lane (#993) via Cesar de la Vega (@vegaro) * Add backend integration tests and test product entitlement mapping endpoint (#988) via Toni Rico (@tonidero) * Fix purchases integration tests (#980) via Toni Rico (@tonidero) * Disable offline entitlements if active inapp purchases exist (#983) via Toni Rico (@tonidero) * Clear cached customer info upon entering offline entitlements mode (#989) via Toni Rico (@tonidero) * Update product entitlement mapping request to new format (#976) via Toni Rico (@tonidero) * Support enabling/disabling offline entitlements (#964) via Toni Rico (@tonidero) * Add back integration tests automation (#972) via Toni Rico (@tonidero) * Upgrade to AGP 8.0 (#975) via Toni Rico (@tonidero) * Extract post receipt logic to PostReceiptHelper (#967) via Toni Rico (@tonidero) * Add isServerDown to error callback for postReceipt and getCustomerInfo requests (#963) via Toni Rico (@tonidero) * Add back integration test flavors (#962) via Toni Rico (@tonidero) * Fix storing test results (#966) via Cesar de la Vega (@vegaro) * Extract detekt job from test job (#965) via Cesar de la Vega (@vegaro) [CF-1324]: https://revenuecats.atlassian.net/browse/CF-1324?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Description
Android Studio Flamingo 8.0 was released a few days ago. As part of the upgrade, it's recommended to upgrade to AGP 8.0 and Gradle 8.0. This PR performs that upgrade.
AGP Upgrade assistant steps run:
In our case:
BuildConfigfiles are used in a couple places so I enabled them only in the modules that use them (common,purchase-testerandMagicWeather).Rfile related steps don't affect us much since we don't really use R resources in the SDK (we do in the sample apps but changes don't affect us there)