Refactor: Remove unnecessary lint suppressions#3373
Merged
Conversation
Co-authored-by: Cesar de la Vega <vegaro@users.noreply.github.com>
vegaro
approved these changes
Apr 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=======================================
Coverage 79.34% 79.34%
=======================================
Files 354 354
Lines 14268 14268
Branches 1951 1951
=======================================
Hits 11321 11321
Misses 2144 2144
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matteinn
pushed a commit
to matteinn/purchases-android
that referenced
this pull request
Apr 28, 2026
**This is an automatic release.** ## RevenueCat SDK ### 🐞 Bugfixes * fix: move Google BillingClient connection off the main thread (RevenueCat#3369) via Toni Rico (@tonidero) * [EXTERNAL] fix(google): guard showInAppMessages against BillingClient runtime crashes (RevenueCat#3367) by @matteinn (RevenueCat#3368) via Monika Mateska (@MonikaMateska) ## RevenueCatUI SDK ### Paywallv2 #### 🐞 Bugfixes * Add Workflows network layer (RevenueCat#3300) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Fix `revenuecat.useWorkflowsEndpoint` compiler flag (RevenueCat#3374) via Cesar de la Vega (@vegaro) * Create paywall from workflow response. Add `USE_WORKFLOWS_ENDPOINT` BuildConfig (RevenueCat#3350) via Cesar de la Vega (@vegaro) * Refactor: Remove unnecessary lint suppressions (RevenueCat#3373) via cursor[bot] (@cursor[bot]) * Bump fastlane-plugin-revenuecat_internal from `a1eed48` to `b822f01` (RevenueCat#3371) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.232.2 to 2.233.0 (RevenueCat#3370) via dependabot[bot] (@dependabot[bot]) * Attempt to fix `AssertionError` "ms is denormalized" in `QueryPurchasesUseCaseTest` (RevenueCat#3361) via Cesar de la Vega (@vegaro) * Update baseline profiles (RevenueCat#3296) via Jaewoong Eum (@skydoves) * fix: reduce precision for flaky HeaderDirectHeroImage snapshot (RevenueCat#3362) via Cesar de la Vega (@vegaro) * Fix test failures reported twice (RevenueCat#3360) via Cesar de la Vega (@vegaro) * refactor: extract `updateStateFromOffering` in `PaywallViewModel` (RevenueCat#3359) via Cesar de la Vega (@vegaro) * [Fix] Include parent tabs component_name in tab-control switch interaction events (RevenueCat#3358) via Monika Mateska (@MonikaMateska) * Refactor: Remove unnecessary lint suppressions (RevenueCat#3348) via cursor[bot] (@cursor[bot]) * fix: always upload CI test results even when tests fail (RevenueCat#3357) via Cesar de la Vega (@vegaro) * refactor: extract `RevenueCatDialogScaffold` (RevenueCat#3355) via Cesar de la Vega (@vegaro) * Fix Slack notifications for nightly integration tests (RevenueCat#3354) via Toni Rico (@tonidero) * UI events for paywall component interactions (RevenueCat#3287) via Monika Mateska (@MonikaMateska) * Bump fastlane-plugin-revenuecat_internal from `20911d1` to `a1eed48` (RevenueCat#3351) via dependabot[bot] (@dependabot[bot]) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Primarily a version bump and release automation updates (docs deploy/redirect and changelog); no functional library code changes beyond updating embedded version constants. > > **Overview** > Cuts the `10.2.1` release by updating version references across the repo (Gradle `VERSION_NAME`, internal `frameworkVersion`, sample/test app dependency pins, and `.version`). > > Updates the docs release pipeline and website redirect to publish and point at `10.2.1`, and refreshes `CHANGELOG.md`/`CHANGELOG.latest.md` with the 10.2.1 release notes. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a0a325b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
A scheduled suppression-cleanup pass identified broad lint suppressions that can be replaced with more explicit control flow and concrete exception handling. This PR removes one unnecessary suppression by refactoring the underlying code while keeping behavior unchanged.
Description
Repository analysis summary
@Suppressand@SuppressLint) and found widespread usage across production, tests, and sample apps.config/detekt/detekt-baseline.xmlcontains active baseline issues (225 IDs).purchases/detekt-baseline.xmlcontains legacy whitelist entries.examples/purchase-tester/detekt-baseline.xmlis currently empty.Suppression removed in this PR
examples/purchase-tester/src/main/java/com/revenuecat/purchasetester/proxysettings/ProxySettingsBottomSheetViewModel.kt@Suppress("TooGenericExceptionCaught")onperformRequestRefactor details
catch (Exception)block with specific exception handling:IOExceptionJSONExceptionIllegalArgumentExceptionerror(...)for non-200 HTTP responses with explicit error state update and early return.ProxySettingsState.Error.Validation
./gradlew :examples:purchase-tester:detektbut this project has no module-leveldetekttask../gradlew :examples:purchase-tester:lint, but lint is blocked in this environment due missing Android SDK configuration (ANDROID_HOME/sdk.dir).Note
Low Risk
Low risk sample-app refactor that narrows exception handling and replaces a hard failure with an explicit error-state update; behavior changes only in how non-200 responses are surfaced to the UI.
Overview
Refactors
ProxySettingsBottomSheetViewModel.performRequestto remove the broad@Suppress("TooGenericExceptionCaught")by catchingIOException,JSONException, andIllegalArgumentExceptionexplicitly.Non-200 proxy responses no longer throw via
error(...); they now updateProxySettingsState.Errorand return early, keeping failures contained to UI state updates.Reviewed by Cursor Bugbot for commit ba56652. Bugbot is set up for automated code reviews on this repo. Configure here.