Skip to content

Fix test failures reported twice#3360

Merged
vegaro merged 3 commits into
mainfrom
cesar/fix-duplicated
Apr 17, 2026
Merged

Fix test failures reported twice#3360
vegaro merged 3 commits into
mainfrom
cesar/fix-duplicated

Conversation

@vegaro

@vegaro vegaro commented Apr 17, 2026

Copy link
Copy Markdown
Member

Example https://app.circleci.com/pipelines/gh/RevenueCat/purchases-android/21113/workflows/b4668dab-588c-43ca-a583-c57620f6449a/jobs/181575/steps

Captura de pantalla 2026-04-17 a las 16 35 23

It was finding xml of the tests twice:

 * /home/circleci/project/build/test-results-collected/ui/revenuecatui/build/test-results/testDefaultsBc8DebugUnitTest/TEST-com.revenuecat.purchases.ui.revenuecatui.data.PaywallViewModelTest.xml
 * /home/circleci/project/build/test-results-collected/build/test-results-collected/ui/revenuecatui/build/test-results/testDefaultsBc8DebugUnitTest/TEST-com.revenuecat.purchases.ui.revenuecatui.data.PaywallViewModelTest.xml 

The second path has build/test-results-collected/build/test-results-collected/..., the copy of the copy. The test fails once, reported twice


Note

Low Risk
Low risk CI-only change that tweaks how JUnit XML artifacts are gathered; main risk is missing test reports if the new find | xargs cp pipeline behaves differently in edge cases (e.g., unusual filenames).

Overview
Prevents CircleCI from re-copying files under build/test-results-collected when gathering JUnit XMLs, eliminating duplicate test report entries.

Replaces the find ... -exec cp approach with a pruned find ... -print0 | xargs -0 cp --parents pipeline in both the main test job and test-galaxy job.

Reviewed by Cursor Bugbot for commit e6a0fdd. Bugbot is set up for automated code reviews on this repo. Configure here.

@vegaro vegaro requested a review from a team as a code owner April 17, 2026 14:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1ad4c9b. Configure here.

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Thanks for fixing!

This reverts commit 1ad4c9b.
@vegaro vegaro enabled auto-merge April 17, 2026 14:52
@emerge-tools

emerge-tools Bot commented Apr 17, 2026

Copy link
Copy Markdown

📸 Snapshot Test

588 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility Paparazzi
com.revenuecat.testpurchasesuiandroidcompatibility.paparazzi
0 0 0 0 257 0 N/A
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
0 0 0 0 331 0 N/A

🛸 Powered by Emerge Tools

@vegaro vegaro added this pull request to the merge queue Apr 17, 2026
@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.36%. Comparing base (27bd0d2) to head (e6a0fdd).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3360   +/-   ##
=======================================
  Coverage   79.36%   79.36%           
=======================================
  Files         354      354           
  Lines       14259    14259           
  Branches     1951     1951           
=======================================
  Hits        11316    11316           
  Misses       2140     2140           
  Partials      803      803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit 532f5e2 Apr 17, 2026
37 of 38 checks passed
@vegaro vegaro deleted the cesar/fix-duplicated branch April 17, 2026 15:29
matteinn pushed a commit to matteinn/purchases-android that referenced this pull request Apr 28, 2026
**This is an automatic release.**

## RevenueCat SDK
### 🐞 Bugfixes
* fix: move Google BillingClient connection off the main thread (RevenueCat#3369)
via Toni Rico (@tonidero)
* [EXTERNAL] fix(google): guard showInAppMessages against BillingClient
runtime crashes (RevenueCat#3367) by @matteinn (RevenueCat#3368) via Monika Mateska
(@MonikaMateska)

## RevenueCatUI SDK
### Paywallv2
#### 🐞 Bugfixes
* Add Workflows network layer (RevenueCat#3300) via Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* Fix `revenuecat.useWorkflowsEndpoint` compiler flag (RevenueCat#3374) via Cesar
de la Vega (@vegaro)
* Create paywall from workflow response. Add `USE_WORKFLOWS_ENDPOINT`
BuildConfig (RevenueCat#3350) via Cesar de la Vega (@vegaro)
* Refactor: Remove unnecessary lint suppressions (RevenueCat#3373) via cursor[bot]
(@cursor[bot])
* Bump fastlane-plugin-revenuecat_internal from `a1eed48` to `b822f01`
(RevenueCat#3371) via dependabot[bot] (@dependabot[bot])
* Bump fastlane from 2.232.2 to 2.233.0 (RevenueCat#3370) via dependabot[bot]
(@dependabot[bot])
* Attempt to fix `AssertionError` "ms is denormalized" in
`QueryPurchasesUseCaseTest` (RevenueCat#3361) via Cesar de la Vega (@vegaro)
* Update baseline profiles (RevenueCat#3296) via Jaewoong Eum (@skydoves)
* fix: reduce precision for flaky HeaderDirectHeroImage snapshot (RevenueCat#3362)
via Cesar de la Vega (@vegaro)
* Fix test failures reported twice (RevenueCat#3360) via Cesar de la Vega
(@vegaro)
* refactor: extract `updateStateFromOffering` in `PaywallViewModel`
(RevenueCat#3359) via Cesar de la Vega (@vegaro)
* [Fix] Include parent tabs component_name in tab-control switch
interaction events (RevenueCat#3358) via Monika Mateska (@MonikaMateska)
* Refactor: Remove unnecessary lint suppressions (RevenueCat#3348) via cursor[bot]
(@cursor[bot])
* fix: always upload CI test results even when tests fail (RevenueCat#3357) via
Cesar de la Vega (@vegaro)
* refactor: extract `RevenueCatDialogScaffold` (RevenueCat#3355) via Cesar de la
Vega (@vegaro)
* Fix Slack notifications for nightly integration tests (RevenueCat#3354) via Toni
Rico (@tonidero)
* UI events for paywall component interactions (RevenueCat#3287) via Monika
Mateska (@MonikaMateska)
* Bump fastlane-plugin-revenuecat_internal from `20911d1` to `a1eed48`
(RevenueCat#3351) via dependabot[bot] (@dependabot[bot])

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Primarily a version bump and release automation updates (docs
deploy/redirect and changelog); no functional library code changes
beyond updating embedded version constants.
> 
> **Overview**
> Cuts the `10.2.1` release by updating version references across the
repo (Gradle `VERSION_NAME`, internal `frameworkVersion`, sample/test
app dependency pins, and `.version`).
> 
> Updates the docs release pipeline and website redirect to publish and
point at `10.2.1`, and refreshes `CHANGELOG.md`/`CHANGELOG.latest.md`
with the 10.2.1 release notes.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
a0a325b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants