Skip to content

[Paywalls V2] Enables template previews again#2215

Merged
JayShortway merged 1 commit into
mainfrom
pw2-reenable-template-previews
Mar 5, 2025
Merged

[Paywalls V2] Enables template previews again#2215
JayShortway merged 1 commit into
mainfrom
pw2-reenable-template-previews

Conversation

@JayShortway

@JayShortway JayShortway commented Mar 5, 2025

Copy link
Copy Markdown
Member

Description

Emerge has fixed the underlying crash triggered by the template previews so we can enable them again. 🎉

So far so good. We'll have to monitor it for a bit after this one gets merged. If we see any issues, we can disable the template previews again. (I have a nearly-ready draft that renders with Paparazzi on CircleCI machines, and then uploads them to Emerge.)

@JayShortway JayShortway self-assigned this Mar 5, 2025
@emerge-tools

emerge-tools Bot commented Mar 5, 2025

Copy link
Copy Markdown

📸 Snapshot Test

6 modified, 17 added, 239 unchanged

Name Added Removed Modified Renamed Unchanged Errored Approval
TestPurchasesUIAndroidCompatibility
com.revenuecat.testpurchasesuiandroidcompatibility
17 0 6 0 239 0 ✅ Approved

🛸 Powered by Emerge Tools

@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (8a1275a) to head (9808778).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2215   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files         278      278           
  Lines        9467     9467           
  Branches     1336     1336           
=======================================
  Hits         7614     7614           
  Misses       1293     1293           
  Partials      560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JayShortway JayShortway requested a review from a team March 5, 2025 08:24
@JayShortway JayShortway marked this pull request as ready for review March 5, 2025 08:24
@JayShortway JayShortway enabled auto-merge (squash) March 5, 2025 08:56

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@JayShortway JayShortway merged commit 77470ac into main Mar 5, 2025
@JayShortway JayShortway deleted the pw2-reenable-template-previews branch March 5, 2025 09:12
tonidero added a commit that referenced this pull request Mar 6, 2025
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add `hasPaywall` property to `Offering` (#2212) via Antonio Pallares
(@ajpallares)
### 🐞 Bugfixes
* Fix empty options in NoActive subscriptions screen (#2168) via Cesar
de la Vega (@vegaro)

## RevenueCatUI SDK
### Customer Center
#### ✨ New Features
* Create `CustomerCenterListener` (#2199) via Cesar de la Vega (@vegaro)
#### 🐞 Bugfixes
* Reload Customer Center after a successful restore (#2203) via Cesar de
la Vega (@vegaro)
* Fixes CustomerCenter state not refreshing when reopening (#2202) via
Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* Improves PaywallsTester multi-API-key support (#2218) via JayShortway
(@JayShortway)
* [EXTERNAL] Bump Emerge Gradle Plugin and Snaphsots version (#2211) via
@runningcode (#2217) via JayShortway (@JayShortway)
* [AUTOMATIC][Paywalls V2] Updates Compose previews of all templates
(#2207) via RevenueCat Git Bot (@RCGitBot)
* [Paywalls V2] Enables template previews again (#2215) via JayShortway
(@JayShortway)
* Adds support for switching between 2 API keys to PaywallsTester
(#2213) via JayShortway (@JayShortway)
* Adds a `LocalPreviewImageLoader` `CompositionLocal`. (#2201) via
JayShortway (@JayShortway)
* Logs from RevenueCatUI are now tagged with `[Purchases]` too. (#2206)
via JayShortway (@JayShortway)
* [Paywalls V2] Ignores template previews for now. (#2209) via
JayShortway (@JayShortway)
* [Paywalls V2] Some more template previews optimizations (#2208) via
JayShortway (@JayShortway)
* chore: Delete key from customer center survey event (#2204) via
Facundo Menzella (@facumenzella)
* [Paywalls V2] Extract ImageLoader to use a single one (#2146) via Toni
Rico (@tonidero)
* [Paywalls V2] Adds progress indicator to buttons (#2198) via
JayShortway (@JayShortway)
* Avoids triggering "unscheduled" workflows when triggering workflows
via the CircleCI API (#2200) via JayShortway (@JayShortway)
* [Paywalls V2] Adds a note on publishing to the missing paywall error.
(#2193) via JayShortway (@JayShortway)
* Adds X-Kotlin-Version header. (#2197) via JayShortway (@JayShortway)
* [Paywalls V2] Adds docs on ignored arguments for Paywalls V2 in more
places. (#2195) via JayShortway (@JayShortway)
* chore: Add backend integration test for events (#2189) via Facundo
Menzella (@facumenzella)
* [Paywalls V2] Adds CI job to update template previews (#2192) via
JayShortway (@JayShortway)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants