Create `CustomerCenterListener` by vegaro · Pull Request #2199 · RevenueCat/purchases-android

vegaro · 2025-02-26T12:04:16Z

This will allow developers to listen to events that occur inside the Customer Center

vegaro · 2025-02-26T12:04:50Z

@RevenueCat/coresdk can you please take a look at this draft, I would like to make sure I get the public stuff right before continuing implementing.

tonidero

I wonder if there is anything we can do to make the interface in kotlin... Probably not the end of the world though. Looking good!

tonidero · 2025-02-26T12:14:13Z

+     * The listener is responsible for handling actions that happened in the Customer Center.
+     * Make sure [removeCustomerCenterListener] is called when the listener needs to be destroyed.
+     */
+    var customerCenterListener: CustomerCenterListener?


I wonder if we would want to support multiple listeners... But then again, this is the API we have for the CustomerInfo, so it might make more sense to be consistent 👍

If someone really needs this they could build a listener that forwards to multiple other listeners themselves. Maybe something we can share as a recipe if we get a few requests.

emerge-tools · 2025-02-27T15:26:02Z

📸 Snapshot Test

5 modified, 240 unchanged

Name	Added	Removed	Modified	Renamed	Unchanged	Errored	Approval
TestPurchasesUIAndroidCompatibility com.revenuecat.testpurchasesuiandroidcompatibility	0	0	5	0	240	0	✅ Approved

🛸 Powered by Emerge Tools

codecov · 2025-03-03T11:29:15Z

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (82a9f29) to head (f17991d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...purchases/customercenter/CustomerCenterListener.kt	0.00%	5 Missing ⚠️
.../com/revenuecat/purchases/PurchasesOrchestrator.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2199      +/-   ##
==========================================
- Coverage   80.47%   80.42%   -0.06%     
==========================================
  Files         277      278       +1     
  Lines        9461     9467       +6     
  Branches     1336     1336              
==========================================
  Hits         7614     7614              
- Misses       1287     1293       +6     
  Partials      560      560

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero

Looks great!

JayShortway

Awesome! Really glad how this turned out! Just a suggestion.

JayShortway · 2025-03-04T11:58:05Z

+     * The listener is responsible for handling actions that happened in the Customer Center.
+     * Make sure [removeCustomerCenterListener] is called when the listener needs to be destroyed.
+     */
+    var customerCenterListener: CustomerCenterListener?


If someone really needs this they could build a listener that forwards to multiple other listeners themselves. Maybe something we can share as a recipe if we get a few requests.

# Conflicts: # examples/paywall-tester/src/main/java/com/revenuecat/paywallstester/MainApplication.kt # examples/paywall-tester/src/main/java/com/revenuecat/paywallstester/ui/screens/main/appinfo/AppInfoScreen.kt # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/customercenter/data/CustomerCenterViewModelTests.kt

# Conflicts: # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/customercenter/data/CustomerCenterViewModelTests.kt

@ajpallares

**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add `hasPaywall` property to `Offering` (#2212) via Antonio Pallares (@ajpallares) ### 🐞 Bugfixes * Fix empty options in NoActive subscriptions screen (#2168) via Cesar de la Vega (@vegaro) ## RevenueCatUI SDK ### Customer Center #### ✨ New Features * Create `CustomerCenterListener` (#2199) via Cesar de la Vega (@vegaro) #### 🐞 Bugfixes * Reload Customer Center after a successful restore (#2203) via Cesar de la Vega (@vegaro) * Fixes CustomerCenter state not refreshing when reopening (#2202) via Cesar de la Vega (@vegaro) ### 🔄 Other Changes * Improves PaywallsTester multi-API-key support (#2218) via JayShortway (@JayShortway) * [EXTERNAL] Bump Emerge Gradle Plugin and Snaphsots version (#2211) via @runningcode (#2217) via JayShortway (@JayShortway) * [AUTOMATIC][Paywalls V2] Updates Compose previews of all templates (#2207) via RevenueCat Git Bot (@RCGitBot) * [Paywalls V2] Enables template previews again (#2215) via JayShortway (@JayShortway) * Adds support for switching between 2 API keys to PaywallsTester (#2213) via JayShortway (@JayShortway) * Adds a `LocalPreviewImageLoader` `CompositionLocal`. (#2201) via JayShortway (@JayShortway) * Logs from RevenueCatUI are now tagged with `[Purchases]` too. (#2206) via JayShortway (@JayShortway) * [Paywalls V2] Ignores template previews for now. (#2209) via JayShortway (@JayShortway) * [Paywalls V2] Some more template previews optimizations (#2208) via JayShortway (@JayShortway) * chore: Delete key from customer center survey event (#2204) via Facundo Menzella (@facumenzella) * [Paywalls V2] Extract ImageLoader to use a single one (#2146) via Toni Rico (@tonidero) * [Paywalls V2] Adds progress indicator to buttons (#2198) via JayShortway (@JayShortway) * Avoids triggering "unscheduled" workflows when triggering workflows via the CircleCI API (#2200) via JayShortway (@JayShortway) * [Paywalls V2] Adds a note on publishing to the missing paywall error. (#2193) via JayShortway (@JayShortway) * Adds X-Kotlin-Version header. (#2197) via JayShortway (@JayShortway) * [Paywalls V2] Adds docs on ignored arguments for Paywalls V2 in more places. (#2195) via JayShortway (@JayShortway) * chore: Add backend integration test for events (#2189) via Facundo Menzella (@facumenzella) * [Paywalls V2] Adds CI job to update template previews (#2192) via JayShortway (@JayShortway) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>

add public layer

68dca02

vegaro added pr:feat A new feature pr:RevenueCatUI feat:Customer Center labels Feb 26, 2025

tonidero reviewed Feb 26, 2025

View reviewed changes

JayShortway reviewed Feb 26, 2025

View reviewed changes

Comment thread purchases/src/defaults/kotlin/com/revenuecat/purchases/Purchases.kt Outdated

JayShortway reviewed Feb 26, 2025

View reviewed changes

Comment thread ...main/kotlin/com/revenuecat/purchases/ui/revenuecatui/customercenter/CustomerCenterOptions.kt Outdated

made some things internal

1eb085a

vegaro added 4 commits February 27, 2025 17:51

remove removeCustomerCenterListener

82aa1df

add default compiler flag

e518837

hook up events

c8b9dcc

sets application listener

0bce4b8

vegaro force-pushed the cc-216-callback-with-actions branch from 5fc0c06 to 0bce4b8 Compare February 28, 2025 13:25

fix API tests

c9338ea

vegaro marked this pull request as ready for review March 3, 2025 11:01

vegaro requested review from a team March 3, 2025 11:01

tonidero approved these changes Mar 3, 2025

View reviewed changes

vegaro enabled auto-merge (squash) March 3, 2025 12:46

Merge branch 'main' into cc-216-callback-with-actions

c789c20

JayShortway approved these changes Mar 4, 2025

View reviewed changes

vegaro added 6 commits March 4, 2025 14:26

remove synchronized from listener

b85a03c

use PurchasesType

724c4b3

Merge branch 'main' into cc-216-callback-with-actions

3eef376

write tests and cleanup

bf66f74

rename to onShowingManageSubscriptions to match iOS

247df7a

vegaro added 2 commits March 4, 2025 19:05

Merge branch 'main' into cc-216-callback-with-actions

89160a6

# Conflicts: # ui/revenuecatui/src/test/kotlin/com/revenuecat/purchases/ui/revenuecatui/customercenter/data/CustomerCenterViewModelTests.kt

fix broken test

f17991d

vegaro merged commit 8a1275a into main Mar 4, 2025

vegaro deleted the cc-216-callback-with-actions branch March 4, 2025 18:58

RCGitBot mentioned this pull request Mar 5, 2025

[AUTOMATIC] Release/8.14.0 #2223

Merged

Uh oh!

Conversation

vegaro commented Feb 26, 2025

Uh oh!

vegaro commented Feb 26, 2025

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

tonidero Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

JayShortway Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

emerge-tools Bot commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

5 modified, 240 unchanged

Uh oh!

codecov Bot commented Mar 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tonidero left a comment

Choose a reason for hiding this comment

Uh oh!

JayShortway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JayShortway Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emerge-tools Bot commented Feb 27, 2025 •

edited

Loading

codecov Bot commented Mar 3, 2025 •

edited

Loading