Skip to content

[Paywalls V2] Adds CI job to update template previews#2192

Merged
JayShortway merged 42 commits into
mainfrom
pw2-template-previews-ci
Feb 25, 2025
Merged

[Paywalls V2] Adds CI job to update template previews#2192
JayShortway merged 42 commits into
mainfrom
pw2-template-previews-ci

Conversation

@JayShortway

@JayShortway JayShortway commented Feb 24, 2025

Copy link
Copy Markdown
Member

This is part 2 of 3:

  1. [#2184] Adds the initial offerings_paywalls_v2_templates.json file, and the previews themselves.
  2. [This one] Adding a Fastlane lane and CircleCI job that updates the offerings_paywalls_v2_templates.json file.
  3. [khepri#12041] Triggering the CircleCI job from the AutoSyncPaywallTemplatesJob in khepri.

Description

  • Adds a new Fastlane lane update_paywall_templates, which calls get_offerings on the Paywalls V2 Template Repo, saves it to a file, and opens a PR .
  • Adds a new CircleCI job and workflow that runs the above lane, triggered by a new update_paywall_templates action.

@codecov

codecov Bot commented Feb 24, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (b4d5f78) to head (d9e6f5e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   80.53%   80.53%           
=======================================
  Files         277      277           
  Lines        9455     9455           
  Branches     1334     1334           
=======================================
  Hits         7615     7615           
  Misses       1280     1280           
  Partials      560      560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! I left a comment, but I think it can be addressed later if we want to get this merged in.

Comment thread fastlane/Fastfile
end

desc "Updates offerings_paywalls_v2_templates.json file and creates/updates PR"
lane :update_paywall_templates do |options|

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could move this entire lane to our fastlane plugin... Since it would be pretty much the same in iOS I imagine once we implement it (other than the file name and maybe the API key?).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that's a great idea! I'll wait to see if we do indeed end up using the same flow in iOS, but if so we should definitely move it to the plugin.

@JayShortway JayShortway merged commit a5756cd into main Feb 25, 2025
@JayShortway JayShortway deleted the pw2-template-previews-ci branch February 25, 2025 11:28
tonidero added a commit that referenced this pull request Mar 6, 2025
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add `hasPaywall` property to `Offering` (#2212) via Antonio Pallares
(@ajpallares)
### 🐞 Bugfixes
* Fix empty options in NoActive subscriptions screen (#2168) via Cesar
de la Vega (@vegaro)

## RevenueCatUI SDK
### Customer Center
#### ✨ New Features
* Create `CustomerCenterListener` (#2199) via Cesar de la Vega (@vegaro)
#### 🐞 Bugfixes
* Reload Customer Center after a successful restore (#2203) via Cesar de
la Vega (@vegaro)
* Fixes CustomerCenter state not refreshing when reopening (#2202) via
Cesar de la Vega (@vegaro)

### 🔄 Other Changes
* Improves PaywallsTester multi-API-key support (#2218) via JayShortway
(@JayShortway)
* [EXTERNAL] Bump Emerge Gradle Plugin and Snaphsots version (#2211) via
@runningcode (#2217) via JayShortway (@JayShortway)
* [AUTOMATIC][Paywalls V2] Updates Compose previews of all templates
(#2207) via RevenueCat Git Bot (@RCGitBot)
* [Paywalls V2] Enables template previews again (#2215) via JayShortway
(@JayShortway)
* Adds support for switching between 2 API keys to PaywallsTester
(#2213) via JayShortway (@JayShortway)
* Adds a `LocalPreviewImageLoader` `CompositionLocal`. (#2201) via
JayShortway (@JayShortway)
* Logs from RevenueCatUI are now tagged with `[Purchases]` too. (#2206)
via JayShortway (@JayShortway)
* [Paywalls V2] Ignores template previews for now. (#2209) via
JayShortway (@JayShortway)
* [Paywalls V2] Some more template previews optimizations (#2208) via
JayShortway (@JayShortway)
* chore: Delete key from customer center survey event (#2204) via
Facundo Menzella (@facumenzella)
* [Paywalls V2] Extract ImageLoader to use a single one (#2146) via Toni
Rico (@tonidero)
* [Paywalls V2] Adds progress indicator to buttons (#2198) via
JayShortway (@JayShortway)
* Avoids triggering "unscheduled" workflows when triggering workflows
via the CircleCI API (#2200) via JayShortway (@JayShortway)
* [Paywalls V2] Adds a note on publishing to the missing paywall error.
(#2193) via JayShortway (@JayShortway)
* Adds X-Kotlin-Version header. (#2197) via JayShortway (@JayShortway)
* [Paywalls V2] Adds docs on ignored arguments for Paywalls V2 in more
places. (#2195) via JayShortway (@JayShortway)
* chore: Add backend integration test for events (#2189) via Facundo
Menzella (@facumenzella)
* [Paywalls V2] Adds CI job to update template previews (#2192) via
JayShortway (@JayShortway)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants