Skip to content

[Paywalls] Synchronize paywall events on app backgrounding and after a purchase#1901

Merged
MarkVillacampa merged 2 commits into
mainfrom
paywall-event-sync
Nov 5, 2024
Merged

[Paywalls] Synchronize paywall events on app backgrounding and after a purchase#1901
MarkVillacampa merged 2 commits into
mainfrom
paywall-event-sync

Conversation

@MarkVillacampa

@MarkVillacampa MarkVillacampa commented Nov 5, 2024

Copy link
Copy Markdown
Member

To improve deliverability of paywall events, try to sync them when the apps is backgrounded and after a new purchase happens.

Checklist

  • If applicable, unit tests
  • If applicable, create follow-up issues for purchases-ios and hybrids

Motivation

Description

@codecov

codecov Bot commented Nov 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (84874c9) to head (4336ee6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1901   +/-   ##
=======================================
  Coverage   82.16%   82.17%           
=======================================
  Files         231      231           
  Lines        8048     8050    +2     
  Branches     1132     1132           
=======================================
+ Hits         6613     6615    +2     
  Misses        986      986           
  Partials      449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MarkVillacampa MarkVillacampa enabled auto-merge (squash) November 5, 2024 10:18
@MarkVillacampa MarkVillacampa merged commit 36d80c8 into main Nov 5, 2024
@MarkVillacampa MarkVillacampa deleted the paywall-event-sync branch November 5, 2024 10:35
tonidero added a commit that referenced this pull request Nov 8, 2024
**This is an automatic release.**

## RevenueCat SDK
### ✨ New Features
* Add `tenjinAnalyticsInstallationId` setter property (#1897) via Toni
Rico (@tonidero)
### 🐞 Bugfixes
* [Fix] Consider a network error as not successfully synced for paywall
events (#1900) via Mark Villacampa (@MarkVillacampa)

### 🔄 Other Changes
* [Paywalls] Synchronize paywall events on app backgrounding and after a
purchase (#1901) via Mark Villacampa (@MarkVillacampa)
* Dispatcher catches and rethrows Throwable instead of Exception to
avoid swallowing errors (#1894) via JayShortway (@JayShortway)

---------

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants