[Fix] Consider a network error as not successfully synced for paywall events#1900
Merged
Conversation
tonidero
approved these changes
Nov 5, 2024
| paywallEventsCallbacks.remove(paywallEventRequest.cacheKey) | ||
| }?.forEach { (_, onErrorHandler) -> | ||
| onErrorHandler(error, true) | ||
| onErrorHandler(error, false) |
Contributor
There was a problem hiding this comment.
I can't think of any reason why we should consider network errors as synced yeah... Might be worth adding some tests for this but this looks good!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
==========================================
+ Coverage 82.16% 82.28% +0.11%
==========================================
Files 231 231
Lines 8048 8048
Branches 1132 1132
==========================================
+ Hits 6613 6622 +9
+ Misses 986 979 -7
+ Partials 449 447 -2 ☔ View full report in Codecov by Sentry. |
tonidero
added a commit
that referenced
this pull request
Nov 8, 2024
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add `tenjinAnalyticsInstallationId` setter property (#1897) via Toni Rico (@tonidero) ### 🐞 Bugfixes * [Fix] Consider a network error as not successfully synced for paywall events (#1900) via Mark Villacampa (@MarkVillacampa) ### 🔄 Other Changes * [Paywalls] Synchronize paywall events on app backgrounding and after a purchase (#1901) via Mark Villacampa (@MarkVillacampa) * Dispatcher catches and rethrows Throwable instead of Exception to avoid swallowing errors (#1894) via JayShortway (@JayShortway) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
purchases-iosand hybridsMotivation
While investigating missing impression events, I found a possible logic issue on Android where we are considering a network error as "successfully synced" and hence deleting any pending events.