Add tenjinAnalyticsInstallationId setter property#1897
Merged
Conversation
tonidero
commented
Nov 4, 2024
| */ | ||
| MIXPANEL_DISTINCT_ID("\$mixpanelDistinctId"), | ||
| FIREBASE_APP_INSTANCE_ID("\$firebaseAppInstanceId"), | ||
| TENJIN_ANALYTICS_INSTALLATION_ID("\$tenjinId"), |
Contributor
Author
There was a problem hiding this comment.
Thought about using $tenjinAnalyticsInstallationId to be more specific, but the backend is currently expecting this, and I don't think we will need to send anything else anytime soon, so decided to leave it as is.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1897 +/- ##
==========================================
- Coverage 82.25% 82.18% -0.07%
==========================================
Files 227 231 +4
Lines 7968 8056 +88
Branches 1121 1132 +11
==========================================
+ Hits 6554 6621 +67
- Misses 967 986 +19
- Partials 447 449 +2 ☔ View full report in Codecov by Sentry. |
MarkVillacampa
approved these changes
Nov 5, 2024
tonidero
added a commit
that referenced
this pull request
Nov 8, 2024
**This is an automatic release.** ## RevenueCat SDK ### ✨ New Features * Add `tenjinAnalyticsInstallationId` setter property (#1897) via Toni Rico (@tonidero) ### 🐞 Bugfixes * [Fix] Consider a network error as not successfully synced for paywall events (#1900) via Mark Villacampa (@MarkVillacampa) ### 🔄 Other Changes * [Paywalls] Synchronize paywall events on app backgrounding and after a purchase (#1901) via Mark Villacampa (@MarkVillacampa) * Dispatcher catches and rethrows Throwable instead of Exception to avoid swallowing errors (#1894) via JayShortway (@JayShortway) --------- Co-authored-by: revenuecat-ops <ops@revenuecat.com> Co-authored-by: Toni Rico <antonio.rico.diez@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new reserved attribute
$tenjinIdand adds a newsetTenjinAnalyticsInstallationIDAPI to the SDK to set it.