Add launchIfNeeded with offeringIdentifier#1533
Merged
Merged
Conversation
tonidero
approved these changes
Dec 22, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Just one question but looks good!
| * @param shouldDisplayDismissButton Whether to display the dismiss button in the paywall. | ||
| */ | ||
| @JvmOverloads | ||
| fun launchIfNeeded( |
Contributor
There was a problem hiding this comment.
Do we also need a version of the launch method that accepts an offeringIdentifier?
tonidero
reviewed
Dec 22, 2023
| @JvmOverloads | ||
| fun launchIfNeeded( | ||
| requiredEntitlementIdentifier: String, | ||
| offeringIdentifier: String? = null, |
Contributor
There was a problem hiding this comment.
Ohh we might want to make this parameter not optional. Otherwise it collides with the other method.
tonidero
approved these changes
Dec 22, 2023
tonidero
approved these changes
Dec 22, 2023
vegaro
pushed a commit
that referenced
this pull request
Dec 22, 2023
**This is an automatic release.** ### RevenueCatUI * Add `launchIfNeeded` with `offeringIdentifier` (#1533) via Cesar de la Vega (@vegaro) * Hide action bar from paywall activity (#1532) via Toni Rico (@tonidero) * Paywalls: improve Chinese localization (#1529) via Andy Boedo (@aboedo) ### Other Changes * Wait for tests to pass when deploying (#1521) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a version of
launchIfNeededthat accepts aofferingIdentifierforpurchases-hybrid-commonto be able to call the function fromPaywallFragment