Skip to content

Paywalls: improve Chinese localization#1529

Merged
aboedo merged 2 commits into
mainfrom
andy/fix/chinese_localization
Dec 21, 2023
Merged

Paywalls: improve Chinese localization#1529
aboedo merged 2 commits into
mainfrom
andy/fix/chinese_localization

Conversation

@aboedo

@aboedo aboedo commented Dec 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Android equivalent to RevenueCat/purchases-ios#3489

I noticed that we don't have a separate file for Chinese Simplified on Android? Is this intentional?

@aboedo aboedo requested review from a team and greenietea December 20, 2023 16:25
@aboedo aboedo self-assigned this Dec 20, 2023
@codecov

codecov Bot commented Dec 20, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b6c4ca) 84.14% compared to head (441a43e) 84.14%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1529   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files         218      218           
  Lines        7196     7196           
  Branches     1007     1007           
=======================================
  Hits         6055     6055           
  Misses        750      750           
  Partials      391      391

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tonidero
tonidero approved these changes Dec 20, 2023
View reviewed changes

@tonidero tonidero left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! As for why we don't have simplified chinese... I'm not sure... @NachoSoto ?

@NachoSoto

NachoSoto commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

I automated the import of languages from iOS. Let me check.

@NachoSoto

NachoSoto commented Dec 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not familiar, would it be zh?
Screenshot 2023-12-20 at 10 18 51

@greenietea

greenietea commented Dec 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

I'm not familiar, would it be zh? Screenshot 2023-12-20 at 10 18 51

both traditional and simplified are represented as zh.

are we meant to also have another file named: ui/revenuecatui/src/main/res/values-zh-rHans/strings.xml where we keep the simplified version?

I was looking at this with the -Hans suffix: https://github.com/francisfeng/purchases-ios/blob/58623b2731cf1e9e0e156d16e3f20130b975de12/RevenueCatUI/Resources/zh-Hans.lproj/Localizable.strings

@aboedo

aboedo commented Dec 21, 2023

Copy link
Copy Markdown
Member Author

I can tackle adding it as a separate PR, thanks!

@aboedo aboedo merged commit 9a352bd into main Dec 21, 2023
@aboedo aboedo deleted the andy/fix/chinese_localization branch December 21, 2023 22:32
@RCGitBot RCGitBot mentioned this pull request Dec 22, 2023
Merged
vegaro pushed a commit that referenced this pull request Dec 22, 2023
@RCGitBot
[AUTOMATIC] Release/7.3.0 (#1535)
c19292b 
**This is an automatic release.**

### RevenueCatUI
* Add `launchIfNeeded` with `offeringIdentifier` (#1533) via Cesar de la
Vega (@vegaro)
* Hide action bar from paywall activity (#1532) via Toni Rico
(@tonidero)
* Paywalls: improve Chinese localization (#1529) via Andy Boedo
(@aboedo)
### Other Changes
* Wait for tests to pass when deploying (#1521) via Cesar de la Vega
(@vegaro)

Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonidero tonidero tonidero approved these changes
@greenietea greenietea greenietea approved these changes
+1 more reviewer
@NachoSoto NachoSoto NachoSoto approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aboedo aboedo

Labels

pr:fix A bug fix pr:RevenueCatUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aboedo @NachoSoto @greenietea @tonidero