Wait for tests to pass when deploying#1521
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 84.36% 84.36%
=======================================
Files 218 218
Lines 7177 7177
Branches 1004 1004
=======================================
Hits 6055 6055
Misses 734 734
Partials 388 388 ☔ View full report in Codecov by Sentry. |
tonidero
approved these changes
Dec 11, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
I guess this new workflow will end up pretty big... but I think it should be fine 👍
| requires: | ||
| - hold | ||
| <<: *release-branches | ||
| - revenuecat/tag-current-branch: |
Contributor
There was a problem hiding this comment.
Haven't checked, but I guess it's ok to have 2 of the same job in the same workflow but with different requirements?
vegaro
pushed a commit
that referenced
this pull request
Dec 22, 2023
**This is an automatic release.** ### RevenueCatUI * Add `launchIfNeeded` with `offeringIdentifier` (#1533) via Cesar de la Vega (@vegaro) * Hide action bar from paywall activity (#1532) via Toni Rico (@tonidero) * Paywalls: improve Chinese localization (#1529) via Andy Boedo (@aboedo) ### Other Changes * Wait for tests to pass when deploying (#1521) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed it's possible to deploy without waiting for all tests to pass. It's probably an edge case but it's possible we merge something into
mainthat breaks unit tests then start a release from that broken commit.I added a new hold job to force the release in case we actually don't want to wait for tests to pass. The name is pretty clear
force-release-without-waiting-for-testsso I think people will understand that it's skipping tests.