Paywalls: Add `PaywallFooterView` by tonidero · Pull Request #1509 · RevenueCat/purchases-android

tonidero · 2023-11-30T18:27:47Z

Description

This adds a new view PaywallFooterView which acts as a wrapper for the PaywallFooter composable. It has some limitations:

Condensed form not supported
Need to set most of the attributes on the construction of the view.

This view will be used in the hybrids in order to support footer view.

tonidero · 2023-11-30T18:29:58Z

+import com.revenuecat.purchases.ui.revenuecatui.PaywallListener
+
+@OptIn(ExperimentalPreviewRevenueCatUIPurchasesAPI::class)
+class PaywallFooterViewActivity : AppCompatActivity() {


Note that it's not needed to use an activity, but this was the easier way to get out from the compose world we use in the MainActivity.

tonidero · 2023-11-30T18:30:28Z

+    <com.revenuecat.purchases.ui.revenuecatui.fragment.PaywallFooterView
+            android:id="@+id/paywall_footer_view"
+            android:background="@android:color/holo_blue_light"
+            android:fontFamily="@font/lobster_two"


Right now I'm hardcoding the font, so we can test it

tonidero · 2023-11-30T18:34:01Z

    options: PaywallOptions,
    condensed: Boolean = false,
-    mainContent: @Composable (PaddingValues) -> Unit,
+    mainContent: @Composable ((PaddingValues) -> Unit)? = null,


This shouldn't be a breaking change, since we're only relaxing the restriction here. I do wonder if this will be confusing and some users will not pass this parameter and try to organize the screen themselves in compose... It should still be fine, but it's probably easier for them to pass us the content there so we can organize it.

I am a bit confused about this change. When would someone not want to set something? This is a footer anywyas

Right... The main reason for this change was that the Column composable inside has a fillMaxSize modifier, which we don't want when we want to render only the footer view. In native android, we probably want people to pass us a composable, but when using the PaywallFooterView, we can't easily pass composables as a parameter to the view (most people using the view are probably not using compose).

An alternative to this would be to add a parameter, useMaxSize or something like that that tells us whether this composable should use all available space. I kinda didn't want to add another parameter if possible, but it might be less error prone than making the content nullable... wdyt?

Hmm, I see... I am seeing now that mainContent is a confusing parameter. It makes it feel as if it's the content of the Footer, and not whatever is behind the Footer

I am honestly leaning towards creating two views, the current PaywallFooter should be something like PaywallFooterWithScreenContent and a new PaywallFooter shouldn't paint anything else and not accept a mainContent

We can discuss this in our weekly sync I think

tonidero · 2023-11-30T18:36:36Z

            ),
        )
    }
+    if (mainContent == null) {


So if we get some composables as a parameter, we will actually take the whole space. If not, we will just use the space needed for the footer.

tonidero · 2023-11-30T18:38:41Z

+<resources>
+    <declare-styleable name="PaywallFooterView">
+        <attr name="android:fontFamily" />
+        <attr name="offeringIdentifier" format="string" />


These are the parameters that can be passed from the xml. This is limited, some of them can only be passed accessing the view programmatically, like the listener.

codecov · 2023-11-30T19:24:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3848f20) 84.50% compared to head (9fab167) 84.50%.
Report is 5 commits behind head on main.

❗ Current head 9fab167 differs from pull request most recent head 07cfe84. Consider uploading reports for the commit 07cfe84 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1509   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         218      218           
  Lines        7211     7211           
  Branches     1004     1004           
=======================================
  Hits         6094     6094           
  Misses        729      729           
  Partials      388      388

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ter view and main content using negative margins

tonidero · 2023-12-01T09:45:21Z

+     * Sets a dismiss handler which will be called when the user successfully purchases or if there is an error
+     * loading the offerings and the user clicks through the error dialog.
+     */
+    fun setDismissHandler(dismissHandler: (() -> Unit)?) {


I wondered whether to remove this for the footer view, since there is already a purchase completed listener in the PaywallListener. But there can still be an error loading the offerings and we show an error dialog in that case, In that case, we want to dismiss it, and this would be the only way to do it.

…venuecatui/views/PaywallFooterView.kt Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>

vegaro · 2023-12-04T16:22:14Z

+            android:background="@android:color/holo_blue_light"
+            android:layout_weight="1"
+            android:layout_width="match_parent"
+            android:layout_height="0dp"


Why is this 0dp?

If you set the layout_weight parameter, you usually need to set one of the dimensions with 0dp so it can grow from that dimension. This is basically telling it to use all the available space after removing the size of other sibling views that don't use layout_weight.

vegaro · 2023-12-04T16:26:48Z

    options: PaywallOptions,
    condensed: Boolean = false,
-    mainContent: @Composable (PaddingValues) -> Unit,
+    mainContent: @Composable ((PaddingValues) -> Unit)? = null,


I am a bit confused about this change. When would someone not want to set something? This is a footer anywyas

### Description Followup to #1509 This adds a `condensed` parameter to the `PaywallFooterView`. This can be set either through the constructor or as an XML parameter.

### Description Full screen counterpart to #1509. This adds a new view `PaywallView` which wraps the `Paywall` composable so it's usable in the view system. The view will be used in the hybrids. --------- Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>

@tonidero

**This is an automatic release.** ### RevenueCatUI * Paywalls: Add `PaywallFooterView` (#1509) via Toni Rico (@tonidero) * Paywalls: Remove `PaywallActivity` theme to pickup application's theme by default (#1511) via Toni Rico (@tonidero) * Paywalls: Auto-close paywall activity if restore grants required entitlement identifier (#1507) via Toni Rico (@tonidero) ### Bugfixes * Improve pricePerYear price calculation precision (#1515) via Toni Rico (@tonidero) * Improve price per month accuracy for weekly subscriptions (#1504) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.0 to 9.4.1 (#1512) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Remove unnecessary appInBackground parameters (#1508) via Cesar de la Vega (@vegaro) * Create `PurchasesStateProvider` (#1502) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>

tonidero added 2 commits November 30, 2023 17:51

WIP: Add PaywallFooterView

f40e3ff

Mostly working now

4872ddd

tonidero added the pr:RevenueCatUI label Nov 30, 2023

tonidero commented Nov 30, 2023

View reviewed changes

Comment thread examples/paywall-tester/src/main/res/layout/activity_paywall_footer_view.xml Outdated

tonidero added 2 commits November 30, 2023 19:32

Remove unneeded line

15ced42

Add new api for PaywallFooter to API tests

201185e

tonidero commented Nov 30, 2023

View reviewed changes

Revert small change and fix detekt

c90e268

tonidero requested a review from a team November 30, 2023 19:05

tonidero added 2 commits December 1, 2023 08:36

Add some basic documentation

5b304ab

Back to previous change and small fix so there is overlap between foo…

bc7c31d

…ter view and main content using negative margins

tonidero commented Dec 1, 2023

View reviewed changes

tonidero added 2 commits December 1, 2023 10:49

Some fixes

fdc29b4

Add xml to api tests

ef6a3d5

tonidero marked this pull request as ready for review December 1, 2023 09:56

tonidero mentioned this pull request Dec 1, 2023

Paywalls: Add PaywallView #1510

Merged

vegaro mentioned this pull request Dec 1, 2023

Add PaywallFooter support RevenueCat/react-native-purchases#799

Merged

vegaro reviewed Dec 1, 2023

View reviewed changes

Comment thread ...nuecatui/src/main/kotlin/com/revenuecat/purchases/ui/revenuecatui/views/PaywallFooterView.kt Outdated

Update ui/revenuecatui/src/main/kotlin/com/revenuecat/purchases/ui/re…

f592058

…venuecatui/views/PaywallFooterView.kt Co-authored-by: Cesar de la Vega <cesarvegaro@gmail.com>

tonidero mentioned this pull request Dec 4, 2023

Paywalls: Add condensed parameter to PaywallFooterView #1513

Merged

vegaro reviewed Dec 4, 2023

View reviewed changes

tonidero and others added 2 commits December 5, 2023 17:51

Paywalls: Add condensed parameter to PaywallFooterView (#1513)

9fab167

### Description Followup to #1509 This adds a `condensed` parameter to the `PaywallFooterView`. This can be set either through the constructor or as an XML parameter.

vegaro enabled auto-merge (squash) December 5, 2023 17:42

vegaro approved these changes Dec 5, 2023

View reviewed changes

vegaro merged commit a6ee1c6 into main Dec 5, 2023

vegaro deleted the add-paywall-footer-view branch December 5, 2023 17:47

RCGitBot mentioned this pull request Dec 5, 2023

[AUTOMATIC] Release/7.2.7 #1517

Merged

Uh oh!

Conversation

tonidero commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonidero Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Nov 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tonidero commented Nov 30, 2023 •

edited

Loading

tonidero Nov 30, 2023 •

edited

Loading

codecov Bot commented Nov 30, 2023 •

edited

Loading