Skip to content

Paywalls: Add condensed parameter to PaywallFooterView#1513

Merged
vegaro merged 1 commit into
add-paywall-footer-viewfrom
add-condensed-parameter-paywall-footer-view
Dec 5, 2023
Merged

Paywalls: Add condensed parameter to PaywallFooterView#1513
vegaro merged 1 commit into
add-paywall-footer-viewfrom
add-condensed-parameter-paywall-footer-view

Conversation

@tonidero

@tonidero tonidero commented Dec 4, 2023

Copy link
Copy Markdown
Contributor

Description

Followup to #1509

This adds a condensed parameter to the PaywallFooterView. This can be set either through the constructor or as an XML parameter.

@tonidero tonidero marked this pull request as ready for review December 4, 2023 08:03
@tonidero tonidero requested a review from a team December 4, 2023 08:03
@codecov

codecov Bot commented Dec 4, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef6a3d5) 84.50% compared to head (109210c) 84.50%.
Report is 1 commits behind head on add-paywall-footer-view.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           add-paywall-footer-view    #1513   +/-   ##
========================================================
  Coverage                    84.50%   84.50%           
========================================================
  Files                          218      218           
  Lines                         7211     7211           
  Branches                      1004     1004           
========================================================
  Hits                          6094     6094           
  Misses                         729      729           
  Partials                       388      388           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegaro vegaro merged commit 9fab167 into add-paywall-footer-view Dec 5, 2023
@vegaro vegaro deleted the add-condensed-parameter-paywall-footer-view branch December 5, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants