Create PurchasesStateProvider#1502
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
+ Coverage 84.46% 84.50% +0.04%
==========================================
Files 217 218 +1
Lines 7196 7211 +15
Branches 1004 1004
==========================================
+ Hits 6078 6094 +16
+ Misses 730 729 -1
Partials 388 388 ☔ View full report in Codecov by Sentry. |
tonidero
reviewed
Nov 27, 2023
tonidero
left a comment
Contributor
There was a problem hiding this comment.
Left some suggestions, lmk what you think!
54affc5 to
94c1ddb
Compare
vegaro
added a commit
that referenced
this pull request
Nov 30, 2023
With #1502 we don't need to pass `appInBackground` as a parameter to the functions in `BillingAbstract`. This PR removes those parameters.
This was referenced Dec 5, 2023
vegaro
pushed a commit
that referenced
this pull request
Dec 5, 2023
**This is an automatic release.** ### RevenueCatUI * Paywalls: Add `PaywallFooterView` (#1509) via Toni Rico (@tonidero) * Paywalls: Remove `PaywallActivity` theme to pickup application's theme by default (#1511) via Toni Rico (@tonidero) * Paywalls: Auto-close paywall activity if restore grants required entitlement identifier (#1507) via Toni Rico (@tonidero) ### Bugfixes * Improve pricePerYear price calculation precision (#1515) via Toni Rico (@tonidero) * Improve price per month accuracy for weekly subscriptions (#1504) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.0 to 9.4.1 (#1512) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Remove unnecessary appInBackground parameters (#1508) via Cesar de la Vega (@vegaro) * Create `PurchasesStateProvider` (#1502) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help removing
appInForegroundas a parameter of many functions, specially in theBillingWrapperSince this could become a very big refactor I decided to just go with changing the getter of
PurchasesOrchestrator.statefor now to get the state held by aPurchasesStateProvider.Future PRs will remove the
appInForegroundparameter and access the state directly.