[MOD-10298] - add check version to json open key#6405
Merged
BenGoldberger merged 2 commits intomasterfrom Jul 6, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6405 +/- ##
==========================================
+ Coverage 89.26% 89.34% +0.07%
==========================================
Files 251 252 +1
Lines 41330 41650 +320
Branches 3623 3963 +340
==========================================
+ Hits 36895 37212 +317
+ Misses 4391 4381 -10
- Partials 44 57 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
reviewed
Jul 2, 2025
alonre24
previously approved these changes
Jul 3, 2025
|
|
alonre24
approved these changes
Jul 3, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.8
git worktree add -d .worktree/backport-6405-to-2.8 origin/2.8
cd .worktree/backport-6405-to-2.8
git switch --create backport-6405-to-2.8
git cherry-pick -x 15203f9c46f040d3741d065eab6c0b7a0e41d340 |
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin 2.10
git worktree add -d .worktree/backport-6405-to-2.10 origin/2.10
cd .worktree/backport-6405-to-2.10
git switch --create backport-6405-to-2.10
git cherry-pick -x 15203f9c46f040d3741d065eab6c0b7a0e41d340 |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jul 6, 2025
* add check version to open key * change to use OpenKey instead (cherry picked from commit 15203f9)
Contributor
|
Successfully created backport PR for |
redisearch-backport-pull-request bot
pushed a commit
that referenced
this pull request
Jul 6, 2025
* add check version to open key * change to use OpenKey instead (cherry picked from commit 15203f9)
Contributor
|
Successfully created backport PR for |
BenGoldberger
added a commit
that referenced
this pull request
Jul 7, 2025
* add check version to open key * change to use OpenKey instead (cherry picked from commit 15203f9)
BenGoldberger
added a commit
that referenced
this pull request
Jul 7, 2025
* add check version to open key * change to use OpenKey instead (cherry picked from commit 15203f9)
BenGoldberger
added a commit
that referenced
this pull request
Jul 8, 2025
* add check version to open key * change to use OpenKey instead (cherry picked from commit 15203f9)
JoanFM
pushed a commit
that referenced
this pull request
Apr 13, 2026
* add check version to open key * change to use OpenKey instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add check that json api version is >=5 before using openKeyWithFlags