Skip to content

[2.10] - add check version to json open key (#6405)#6455

Merged
BenGoldberger merged 1 commit into2.10from
backport-6405-to-2.10
Jul 7, 2025
Merged

[2.10] - add check version to json open key (#6405)#6455
BenGoldberger merged 1 commit into2.10from
backport-6405-to-2.10

Conversation

@BenGoldberger
Copy link
Copy Markdown
Collaborator

  • add check version to open key

  • change to use OpenKey instead

(cherry picked from commit 15203f9)

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

* add check version to open key

* change to use OpenKey instead

(cherry picked from commit 15203f9)
@BenGoldberger BenGoldberger requested a review from alonre24 July 7, 2025 07:51
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (a4afbc3) to head (c20aefe).
Report is 2 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/document_basic.c 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #6455      +/-   ##
==========================================
- Coverage   89.31%   89.28%   -0.03%     
==========================================
  Files         204      204              
  Lines       36044    36047       +3     
==========================================
- Hits        32192    32184       -8     
- Misses       3852     3863      +11     
Flag Coverage Δ
flow 83.80% <75.00%> (-0.16%) ⬇️
unit 42.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenGoldberger BenGoldberger added this pull request to the merge queue Jul 7, 2025
Merged via the queue into 2.10 with commit eacd9f8 Jul 7, 2025
10 of 11 checks passed
@BenGoldberger BenGoldberger deleted the backport-6405-to-2.10 branch July 7, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants