Skip to content

[2.8] - add check version to json open key (#6405)#6456

Merged
BenGoldberger merged 1 commit into2.8from
backport-6405-to-2.8
Jul 7, 2025
Merged

[2.8] - add check version to json open key (#6405)#6456
BenGoldberger merged 1 commit into2.8from
backport-6405-to-2.8

Conversation

@BenGoldberger
Copy link
Copy Markdown
Collaborator

@BenGoldberger BenGoldberger commented Jul 7, 2025

  • add check version to open key

  • change to use OpenKey instead

(cherry picked from commit 15203f9)

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

@BenGoldberger
[MOD-10298] - add check version to json open key (#6405)
dbcbfc9 
* add check version to open key

* change to use OpenKey instead

(cherry picked from commit 15203f9)
@BenGoldberger BenGoldberger requested a review from alonre24 July 7, 2025 07:51
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.04%. Comparing base (4866bf1) to head (dbcbfc9).
Report is 96 commits behind head on 2.8.

Files with missing lines Patch % Lines
src/document_basic.c 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              2.8    #6456      +/-   ##
==========================================
+ Coverage   85.83%   87.04%   +1.21%     
==========================================
  Files         199      203       +4     
  Lines       34235    35840    +1605     
==========================================
+ Hits        29386    31198    +1812     
+ Misses       4849     4642     -207
Flag Coverage Δ
flow 81.24% <75.00%> (?)
unit 42.63% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenGoldberger BenGoldberger added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 7, 2025
@BenGoldberger BenGoldberger added this pull request to the merge queue Jul 7, 2025
Merged via the queue into 2.8 with commit 007d3f8 Jul 7, 2025
10 of 11 checks passed
@BenGoldberger BenGoldberger deleted the backport-6405-to-2.8 branch July 7, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alonre24 alonre24 alonre24 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BenGoldberger @alonre24