Hadle JSON.DEL logs [MOD-10266] by BenGoldberger · Pull Request #6377 · RediSearch/RediSearch

BenGoldberger · 2025-06-26T13:02:25Z

this PR should clean the warning logs when deleting a json doc
And set the index errors for some flows

codecov · 2025-06-26T13:32:42Z

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.52%. Comparing base (884da8c) to head (e95f693).
Report is 24 commits behind head on master.

Files with missing lines	Patch %	Lines
src/json.c	50.00%	2 Missing ⚠️
src/info/index_error.c	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6377      +/-   ##
==========================================
+ Coverage   88.81%   89.52%   +0.70%     
==========================================
  Files         251      253       +2     
  Lines       41604    41549      -55     
  Branches     3623     3963     +340     
==========================================
+ Hits        36950    37195     +245     
+ Misses       4610     4297     -313     
- Partials       44       57      +13

Flag	Coverage Δ
flow	`82.13% <50.00%> (+0.61%)`	⬆️
unit	`47.37% <0.00%> (+0.71%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CLAassistant · 2025-07-03T11:34:05Z

All committers have signed the CLA.

redisearch-backport-pull-request · 2025-07-07T15:00:36Z

Backport failed for 2.8, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.8
git worktree add -d .worktree/backport-6377-to-2.8 origin/2.8
cd .worktree/backport-6377-to-2.8
git switch --create backport-6377-to-2.8
git cherry-pick -x 1243f48e4e46fb0399772ef659a9d60a6dd77163

redisearch-backport-pull-request · 2025-07-07T15:00:38Z

Backport failed for 2.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 2.6
git worktree add -d .worktree/backport-6377-to-2.6 origin/2.6
cd .worktree/backport-6377-to-2.6
git switch --create backport-6377-to-2.6
git cherry-pick -x 1243f48e4e46fb0399772ef659a9d60a6dd77163

* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48)

redisearch-backport-pull-request · 2025-07-07T15:00:42Z

Successfully created backport PR for 2.10:

[2.10] Hadle JSON.DEL logs [MOD-10266] #6461

* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48)

redisearch-backport-pull-request · 2025-07-07T15:00:46Z

Successfully created backport PR for 8.0:

[8.0] Hadle JSON.DEL logs [MOD-10266] #6462

* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48)

redisearch-backport-pull-request · 2025-07-07T15:00:50Z

Successfully created backport PR for 8.2:

[8.2] Hadle JSON.DEL logs [MOD-10266] #6463

* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48)

Hadle JSON.DEL logs [MOD-10266] (#6377) * set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48) Co-authored-by: BenGoldberger <ben.goldberger@redis.com>

* Hadle JSON.DEL logs [MOD-10266] (#6377) * set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48) * remove skip json --------- Co-authored-by: BenGoldberger <ben.goldberger@redis.com>

* Hadle JSON.DEL logs [MOD-10266] (#6377) * set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48) * remove set error * move unecessery tests * add couldnt open key error * document does not exist

* Hadle JSON.DEL logs [MOD-10266] (#6377) * set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48) * move set error * add error when couldnt open key

DvirDukhan · 2025-07-16T11:55:39Z

Compliance Analysis:

✅ COMPLIANT: Jira DoD requires changing log level from warning to debug - PR successfully updates log level in src/info/index_error.c.
✅ COMPLIANT: Jira DoD requires improving error handling by setting status details during JSON document updates - PR enhances error handling in src/document_basic.c and src/json.c.
⚠️ PARTIAL: PR introduces potential issues with logging level changes and error message clarity, which may need further refinement for end-user understanding.

Actionable Recommendations:

Address potential issues by revisiting the logging level changes to ensure critical errors remain visible.
Enhance error message clarity for better user feedback and understanding.

The PR implementation aligns well with the Jira requirements, with minor areas for improvement to enhance user experience and error visibility.

* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors

set the errors when needed and change log level to debug

b0cf7d9

github-actions bot added the size:XS label Jun 26, 2025

add tests

2d08c73

github-actions bot added the size:M label Jun 29, 2025

BenGoldberger added 2 commits June 29, 2025 14:19

skip cluster

7b608be

change test

25d481a

BenGoldberger added 5 commits July 6, 2025 11:21

simplify test

6f5ecad

add verbose to test

290e71f

ad print for rltest_config

1c23bfd

add some test to json error

c6a9af8

add some test to json errors

e95f693

BenGoldberger requested a review from GuyAv46 July 7, 2025 12:09

GuyAv46 approved these changes Jul 7, 2025

View reviewed changes

GuyAv46 removed the size:XS label Jul 7, 2025

BenGoldberger added backport 2.8 backport 2.6 backport 2.10 backport 8.0 backport 8.2 labels Jul 7, 2025

BenGoldberger added this pull request to the merge queue Jul 7, 2025

Merged via the queue into master with commit 1243f48 Jul 7, 2025
31 of 32 checks passed

BenGoldberger deleted the beng-handle-json.del-logs branch July 7, 2025 15:00

redisearch-backport-pull-request bot mentioned this pull request Jul 7, 2025

[2.10] Hadle JSON.DEL logs [MOD-10266] #6461

Merged

redisearch-backport-pull-request bot mentioned this pull request Jul 7, 2025

[8.0] Hadle JSON.DEL logs [MOD-10266] #6462

Merged

redisearch-backport-pull-request bot mentioned this pull request Jul 7, 2025

[8.2] Hadle JSON.DEL logs [MOD-10266] #6463

Merged

This was referenced Jul 8, 2025

[2.6] Hadle JSON.DEL logs [MOD-10266] #6467

Merged

[2.8] Hadle JSON.DEL logs [MOD-10266] #6466

Merged

ofiryanai mentioned this pull request Jul 10, 2025

[BUG] Index error occurred but no index error message was set. #6483

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hadle JSON.DEL logs [MOD-10266]#6377

Hadle JSON.DEL logs [MOD-10266]#6377
BenGoldberger merged 9 commits intomasterfrom
beng-handle-json.del-logs

BenGoldberger commented Jun 26, 2025

Uh oh!

codecov bot commented Jun 26, 2025 •

edited

Loading

Uh oh!

CLAassistant commented Jul 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

DvirDukhan commented Jul 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

BenGoldberger commented Jun 26, 2025

Uh oh!

codecov bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CLAassistant commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

redisearch-backport-pull-request bot commented Jul 7, 2025

Uh oh!

DvirDukhan commented Jul 16, 2025

Compliance Analysis:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 26, 2025 •

edited

Loading

CLAassistant commented Jul 3, 2025 •

edited

Loading