[2.8] Hadle JSON.DEL logs [MOD-10266]#6466
Merged
BenGoldberger merged 3 commits into2.8from Jul 9, 2025
Merged
Conversation
* set the errors when needed and change log level to debug * add tests * skip cluster * change test * simplify test * add verbose to test * ad print for rltest_config * add some test to json error * add some test to json errors (cherry picked from commit 1243f48)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.8 #6466 +/- ##
==========================================
- Coverage 87.51% 87.49% -0.02%
==========================================
Files 202 202
Lines 35590 35596 +6
==========================================
- Hits 31146 31145 -1
- Misses 4444 4451 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GuyAv46
requested changes
Jul 8, 2025
Collaborator
GuyAv46
left a comment
There was a problem hiding this comment.
missing failure to open key error
GuyAv46
approved these changes
Jul 9, 2025
Collaborator
GuyAv46
left a comment
There was a problem hiding this comment.
I'd expect at least some of the new errors to be covered by the new tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(#6377)
set the errors when needed and change log level to debug
add tests
skip cluster
change test
simplify test
add verbose to test
ad print for rltest_config
add some test to json error
add some test to json errors
(cherry picked from commit 1243f48)
Describe the changes in the pull request
A clear and concise description of what the PR is solving, including:
Which additional issues this PR fixes
Main objects this PR modified
Mark if applicable