Skip to content

[2.6] Hadle JSON.DEL logs [MOD-10266]#6467

Merged
BenGoldberger merged 5 commits into2.6from
backport-6377-to-2.6
Jul 9, 2025
Merged

[2.6] Hadle JSON.DEL logs [MOD-10266]#6467
BenGoldberger merged 5 commits into2.6from
backport-6377-to-2.6

Conversation

@BenGoldberger
Copy link
Copy Markdown
Collaborator

@BenGoldberger BenGoldberger commented Jul 8, 2025

(#6377)

  • set the errors when needed and change log level to debug

  • add tests

  • skip cluster

  • change test

  • simplify test

  • add verbose to test

  • ad print for rltest_config

  • add some test to json error

  • add some test to json errors

(cherry picked from commit 1243f48)

Describe the changes in the pull request

A clear and concise description of what the PR is solving, including:

  1. Current: The current state briefly
  2. Change: What is the change
  3. Outcome: Adding the outcome

Which additional issues this PR fixes

  1. MOD-...
  2. #...

Main objects this PR modified

  1. ...

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

* set the errors when needed and change log level to debug

* add tests

* skip cluster

* change test

* simplify test

* add verbose to test

* ad print for rltest_config

* add some test to json error

* add some test to json errors

(cherry picked from commit 1243f48)
@GuyAv46 GuyAv46 changed the title [2.6] Hadle JSON.DEL logs [MOD-10266] (#6377) [2.6] Hadle JSON.DEL logs [MOD-10266] Jul 8, 2025
Copy link
Copy Markdown
Collaborator

@GuyAv46 GuyAv46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing failure to open key error

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.37%. Comparing base (345c290) to head (cefc421).
Report is 1 commits behind head on 2.6.

Files with missing lines Patch % Lines
src/json.c 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.6    #6467      +/-   ##
==========================================
- Coverage   86.42%   86.37%   -0.05%     
==========================================
  Files         185      185              
  Lines       32247    32252       +5     
==========================================
- Hits        27868    27858      -10     
- Misses       4379     4394      +15     
Flag Coverage Δ
flow 80.04% <33.33%> (-0.30%) ⬇️
unit 46.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BenGoldberger BenGoldberger added this pull request to the merge queue Jul 9, 2025
Merged via the queue into 2.6 with commit 81d7f90 Jul 9, 2025
15 of 18 checks passed
@BenGoldberger BenGoldberger deleted the backport-6377-to-2.6 branch July 9, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants