Skip to content

gnrc_sixlowpan_nd_router: initial import of router behavior of 6LoWPAN-ND#3749

Merged
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_nd_router/feat/initial
Sep 10, 2015
Merged

gnrc_sixlowpan_nd_router: initial import of router behavior of 6LoWPAN-ND#3749
OlegHahm merged 2 commits intoRIOT-OS:masterfrom
miri64:gnrc_sixlowpan_nd_router/feat/initial

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 31, 2015

This imports router behavior for 6LoWPAN-ND and adapts GNRC accordingly

Depends on:

@miri64 miri64 added Area: network Area: Networking Type: new feature The issue requests / The PR implemements a new feature for RIOT State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Aug 31, 2015
@miri64 miri64 added this to the Release 2015.08 milestone Aug 31, 2015
@miri64 miri64 mentioned this pull request Aug 31, 2015
Merged
@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from e920db6 to 2ec9217 Compare August 31, 2015 23:29
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 31, 2015

Rebased to current master and dependencies

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch 2 times, most recently from f9df945 to b212728 Compare September 2, 2015 21:33
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 2, 2015

Rebased to current master and dependenies

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from b212728 to dffc702 Compare September 2, 2015 22:34
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 2, 2015

Rebased to current #3748.

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch 2 times, most recently from 7c81c0d to 7222b05 Compare September 3, 2015 08:30
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 3, 2015

Rebased to current #3748

This was referenced Sep 7, 2015
Closed
Merged
@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from 7222b05 to 6c6579a Compare September 7, 2015 20:33
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 7, 2015

Rebased to current #3748 and reverted the temporary fix for configuration of solicited-nodes multicast addresses.

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from 6c6579a to e1b81f7 Compare September 8, 2015 18:42
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 8, 2015

Rebased to current #3748

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from e1b81f7 to 761e2b8 Compare September 9, 2015 10:02
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 9, 2015

Rebased to current master

@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 9, 2015
@miri64 miri64 mentioned this pull request Sep 9, 2015
Closed
OlegHahm
OlegHahm reviewed Sep 9, 2015
View reviewed changes
sys/include/net/gnrc/sixlowpan/nd/router.h
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Sep 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These setter functions look much like Java code to me.

Copy link
Copy Markdown
Member Author

@miri64 miri64 Sep 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit-operations are not typical java operations. Moreover, it makes https://github.com/RIOT-OS/RIOT/pull/3749/files#diff-f9bf85cb337616822921e4230ede1572R239 more readable.

Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Sep 9, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that anything gets more readable by replacing an assignment by a function and IMO it adds just 18 lines of additional code plus documentation, but this is not a blocker for this PR.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 9, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 9, 2015

Fixed doc issue

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 9, 2015

Not really related to this PR, but fixing parsing of router advertisements in general: miri64#20

@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 10, 2015
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 10, 2015

ACK, please squash.

@miri64 miri64 force-pushed the gnrc_sixlowpan_nd_router/feat/initial branch from 6c180cf to 40912d3 Compare September 10, 2015 00:14
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 10, 2015

Squashed

@miri64 miri64 removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Sep 10, 2015
OlegHahm added a commit that referenced this pull request Sep 10, 2015
@OlegHahm
Merge pull request #3749 from authmillenon/gnrc_sixlowpan_nd_router/f…
8b16f3e 
…eat/initial

gnrc_sixlowpan_nd_router: initial import of router behavior of 6LoWPAN-ND
@OlegHahm OlegHahm merged commit 8b16f3e into RIOT-OS:master Sep 10, 2015
@OlegHahm OlegHahm mentioned this pull request Sep 10, 2015
Merged
@miri64 miri64 deleted the gnrc_sixlowpan_nd_router/feat/initial branch September 10, 2015 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@OlegHahm OlegHahm

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT

Projects

None yet

Milestone

Release 2015.09

Development

Successfully merging this pull request may close these issues.

2 participants

@miri64 @OlegHahm