gnrc_ipv6_netif: prepare for router discovery#3745
Conversation
sys/include/net/gnrc/ipv6/netif.h
Outdated
There was a problem hiding this comment.
s/GNRC_NDP_NETIF_MAX_ADV_INT_DEFAULT/GNRC_IPV6_NETIF_DEFAULT_MAX_ADV_INT/
1b6bc03 to
4b60189
Compare
|
Addressed comments. |
There was a problem hiding this comment.
Added so I don't have to document the dummy macros (and so that the functions show up in the documentation)
|
Addressed comments |
|
please squash |
e4dbe8a to
ccf1e4d
Compare
|
Squashed |
ccf1e4d to
cd2208a
Compare
|
Rebased to current master |
|
@cgundogan, do you ACK? |
There was a problem hiding this comment.
Could you briefly explain why these dummy defines are needed? I don't have the full picture in mind and couldn't find any references in the current RIOT code.
There was a problem hiding this comment.
Wouldn't it be much cleaner to separate those functions out of the current header file and include this file only if MODULE_XYZ is defined?
There was a problem hiding this comment.
Wouldn't it be much cleaner to separate those functions out of the current header file and include this file only if MODULE_XYZ is defined?
They are. These functions call these functions in the other modules (gnrc_ndp_router and gnrc_sixlowpan_router_nd respectively) if the modules exist, depending if the interface is a 6LoWPAN interface or not.
There was a problem hiding this comment.
So, why are these functions called for non-routers in the first place?
There was a problem hiding this comment.
Ok, so the choice was an ifdef in the header against multiple in the C files?
There was a problem hiding this comment.
I would've preferred the #ifdef in the C-File. This way it wouldn't be necessary to add an entry in the riot.doxyfile. But you know what they say.. de gustibus non est disputandum.
There was a problem hiding this comment.
Plus it looks weird here, but @cgundogan is right - and in the worst case we can change this later on.
|
ACK, squash and GO |
739ac00 to
b81a4dd
Compare
…sc-prep gnrc_ipv6_netif: prepare for router discovery
Adds some new flags and fields to the IPv6 interfaces required for router discovery (and also makes some functions private, that turned out to be a little bit more complicated there).