Skip to content

gnrc_ipv6_nc: adapt neighbor cache for different ND implementations#3744

Merged
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_nc/enh/6lo-nd
Sep 2, 2015
Merged

gnrc_ipv6_nc: adapt neighbor cache for different ND implementations#3744
OlegHahm merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_ipv6_nc/enh/6lo-nd

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Aug 30, 2015

Preparation PR for #3748 and follow-ups

Depends on #3628, since that one changes a lot in gnrc_ndp.c (including lines that the adaptations for this PR are touching) and I want to have as few as possible merge conflicts when rebasing #3134. (merged)

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking State: waiting for other PR State: The PR requires another PR to be merged first NSTF labels Aug 30, 2015
@miri64 miri64 added this to the Release 2015.08 milestone Aug 30, 2015
@miri64 miri64 force-pushed the gnrc_ipv6_nc/enh/6lo-nd branch from a8eaf60 to bfdcebe Compare August 31, 2015 23:15
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Aug 31, 2015

Rebased to current #3628.

@miri64 miri64 force-pushed the gnrc_ipv6_nc/enh/6lo-nd branch from bfdcebe to a658040 Compare September 2, 2015 12:21
@miri64 miri64 removed the State: waiting for other PR State: The PR requires another PR to be merged first label Sep 2, 2015
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 2, 2015

Rebased to current master. Ready for review.

@OlegHahm OlegHahm added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 2, 2015
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this module should not (never?) be defined if building for 6LoWPAN?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you only build for 6LoWPAN, yes. For border routers with ethernet support or similar, this might be included regardless and multi-NDP support kicks in.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can reflect this somehow in the Makefile.dep.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant something that would explicitly remove this module from the used modules in a non-border router case.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not topic of this PR #3748 introduces this feature.

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Sep 2, 2015

Travis seems to be happy, though no ACK was given... I'm confused

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 2, 2015

I triggered Travis in advance in order to shorten things.

@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Sep 2, 2015

However, ACK and go!

OlegHahm added a commit that referenced this pull request Sep 2, 2015
gnrc_ipv6_nc: adapt neighbor cache for different ND implementations
@OlegHahm OlegHahm merged commit 4fa3bb8 into RIOT-OS:master Sep 2, 2015
@miri64 miri64 deleted the gnrc_ipv6_nc/enh/6lo-nd branch September 2, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants