Skip to content

pkg: avoid copying Makefiles in package source when possible#14251

Merged
leandrolanzieri merged 12 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/make_enh
Jun 16, 2020
Merged

pkg: avoid copying Makefiles in package source when possible#14251
leandrolanzieri merged 12 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/make_enh

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 10, 2020

Contribution description

This PR remove all uses of cp that copy Makefile in the package sources, only the obvious cases. More "complex" cases are handled independently by #14248, #14249 and #14250.

There are a couple of other commits that:

  • remove inconsistent uses of $(Q) to silent the make command
  • remove a redundant use of .PHONY: all => this is already done in pkg.mk

Testing procedure

  • Green Murdock

Issues/PRs references

None

@aabadie aabadie added Area: build system Area: Build system Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2020
@aabadie aabadie requested a review from leandrolanzieri as a code owner June 12, 2020 15:31
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 12, 2020

I've extended a little this PR:

  • where possible, packages use the main Makefile.base file directly from the command line. There's no need to add an extra Makefile.<package> for this.
  • on some packages, I removed patches that were adding a Makefile to the package source. This is not necessary if we use the -f option.

@aabadie aabadie mentioned this pull request Jun 15, 2020
Merged
@leandrolanzieri leandrolanzieri self-assigned this Jun 16, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 16, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 16, 2020
leandrolanzieri
leandrolanzieri approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri merged commit 2546f92 into RIOT-OS:master Jun 16, 2020
@aabadie aabadie deleted the pr/pkg/make_enh branch June 16, 2020 15:07
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 16, 2020

Awesome! thanks you very much for the review @leandrolanzieri!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: build system Area: Build system Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @leandrolanzieri