Skip to content

pkg/tinydtls: cleanup build system integration#14249

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/tinydtls_make
Jun 10, 2020
Merged

pkg/tinydtls: cleanup build system integration#14249
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/tinydtls_make

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 10, 2020

Contribution description

This PR is a small cleanup of the tinydtls package integration in the build system: instead of renaming existing RIOT-compatible Makefile in the package code, just use the -f option of make with the original Makefile.
Then there's also no need to add new DIRS from the package source code and it's allows to keep the package code untouched.

Testing procedure

  • A green Murdock
  • examples/dtls-echo is still working

Issues/PRs references

None

@aabadie aabadie added Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2020
@aabadie aabadie requested a review from leandrolanzieri as a code owner June 10, 2020 14:57
@aabadie aabadie mentioned this pull request Jun 10, 2020
Merged
leandrolanzieri
leandrolanzieri reviewed Jun 10, 2020
View reviewed changes
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Jun 10, 2020
leandrolanzieri
leandrolanzieri approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building of the package is now cleaner. The example still works. ACK.

@leandrolanzieri leandrolanzieri merged commit e2f20d6 into RIOT-OS:master Jun 10, 2020
@aabadie aabadie deleted the pr/pkg/tinydtls_make branch June 10, 2020 16:37
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @leandrolanzieri