Skip to content

pkg/wakaama: cleanup build system integration#14248

Merged
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/wakaama_make
Jun 10, 2020
Merged

pkg/wakaama: cleanup build system integration#14248
leandrolanzieri merged 2 commits intoRIOT-OS:masterfrom
aabadie:pr/pkg/wakaama_make

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 10, 2020

Contribution description

This PR cleans up the build system integration of the wakaama package: instead of moving files in the cloned repository, use specific modules using the -f option of make. This allows to keep the repository untouched and thus is easier to maintain.

Since there's no concrete wakaama module anymore, it's now added as a pseudomodule.

Testing procedure

  • A green Murdock
  • Verify that examples/wakaama is still working

Issues/PRs references

None

@aabadie aabadie added Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2020
@aabadie aabadie requested a review from leandrolanzieri as a code owner June 10, 2020 14:54
@aabadie aabadie mentioned this pull request Jun 10, 2020
Merged
leandrolanzieri
leandrolanzieri approved these changes Jun 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, the Makefile is now much cleaner. The example still works. ACK.

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Jun 10, 2020
@leandrolanzieri leandrolanzieri merged commit a4889b4 into RIOT-OS:master Jun 10, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 10, 2020
@aabadie aabadie deleted the pr/pkg/wakaama_make branch June 10, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

Assignees

No one assigned

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @leandrolanzieri