Skip to content

pkg/semtech-loramac: cleanup build system integration#14250

Merged
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech_loramac_make
Jun 16, 2020
Merged

pkg/semtech-loramac: cleanup build system integration#14250
leandrolanzieri merged 1 commit intoRIOT-OS:masterfrom
aabadie:pr/pkg/semtech_loramac_make

Conversation

@aabadie
Copy link
Copy Markdown
Contributor

@aabadie aabadie commented Jun 10, 2020

Contribution description

This PR cleans up the build system integration of the semtech-loramac package: instead of copying Makefiles in each cloned repository, just use the one provided locally using the -f option of make.

Some extra cleanup are also added (:= => =, SRCS => SRC).

Since the semtech-loramac module is not a concrete module anymore, it's added to the pseudomodules list.

Testing procedure

  • A green Murdock
  • tests/pkg_semtech-loramac still functional

Issues/PRs references

None

@aabadie
pkg/semtech-loramac: cleanup build system integration
1204435 
Avoid copying Makefile in the cloned directory
@aabadie aabadie added Area: pkg Area: External package ports Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jun 10, 2020
@aabadie aabadie requested a review from jia200x as a code owner June 10, 2020 15:02
This was referenced Jun 10, 2020
Merged
Merged
@leandrolanzieri leandrolanzieri self-assigned this Jun 16, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines labels Jun 16, 2020
leandrolanzieri
leandrolanzieri reviewed Jun 16, 2020
View reviewed changes
pkg/semtech-loramac/Makefile

all: $(LORAMAC_MODULES)

loramac_%:
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

leandrolanzieri
leandrolanzieri approved these changes Jun 16, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and the test application still works as usual. ACK.

@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 16, 2020
@leandrolanzieri leandrolanzieri merged commit 8957008 into RIOT-OS:master Jun 16, 2020
@aabadie aabadie deleted the pr/pkg/semtech_loramac_make branch June 16, 2020 12:16
@aabadie
Copy link
Copy Markdown
Contributor Author

aabadie commented Jun 16, 2020

Thank you for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

Assignees

@leandrolanzieri leandrolanzieri

Labels

Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2020.07

Development

Successfully merging this pull request may close these issues.

2 participants

@aabadie @leandrolanzieri