board: Initial import of stm32f4discovery board by haukepetersen · Pull Request #1191 · RIOT-OS/RIOT

haukepetersen · 2014-05-16T12:15:54Z

~~This is still WIP, left TODOs are:~~

testing of GPIO, UART and timers
removing compiler warnings
cleaning up documentation (and comment styles)
disabling newlib-nano specs by default
handling of FPU (saving and restoring FPU context) -> see issue FPU support for the Cortex-M4F family #1366
remodel cortexm_common into cortex-m4_common

Kijewski · 2014-05-16T12:23:42Z

Can't you feature test if newlib-nano is available? Compare Makefile.cflags.

haukepetersen · 2014-05-16T12:28:10Z

That is actually a good idea, will look into this.

mehlis · 2014-05-30T17:16:01Z

@haukepetersen can we this PR as a goal for IOTweek?

haukepetersen · 2014-06-02T13:05:32Z

sure

haukepetersen · 2014-06-05T18:24:35Z

Ok nano-specs are now optional. Will test and make this PR ready next week.

LudwigKnuepfer · 2014-06-06T09:07:57Z

can you make the TODOs a checkbox list?

 - [ ] foo

haukepetersen · 2014-06-06T09:11:37Z

Certainly

LudwigKnuepfer · 2014-06-06T09:48:31Z

great =)

haukepetersen · 2014-06-10T18:57:47Z

Rebased this branch and did some fixes - still some parts to do, though...

Kijewski · 2014-06-10T19:15:50Z

boards/stm32f4discovery/include/board.h

guess what. :)

I see I see :-)

haukepetersen · 2014-06-24T16:39:40Z

Adressed @Kijewski issues, fixed compiler warnings, cleaned up task-switching code and rebased.

LudwigKnuepfer · 2014-06-25T06:13:51Z

Your license header is not known - I suggest you use the old-style header and let it be fixed in #1329 .

LudwigKnuepfer · 2014-06-25T06:15:22Z

Otherwise you could also add this new pattern to dist/tools/licenses/patterns/...

haukepetersen · 2014-06-25T12:07:58Z

Ok, I will reverse to the old header once I have time.

LudwigKnuepfer · 2014-06-25T13:59:28Z

@haukepetersen see haukepetersen#1

haukepetersen · 2014-06-26T10:26:46Z

nice, merged it into this PR.

LudwigKnuepfer · 2014-06-27T09:36:05Z

rebase!

haukepetersen · 2014-06-30T11:26:51Z

rebased.

haukepetersen · 2014-07-03T14:11:42Z

Not WIP anymore: now finally fully tested and functioning, please test!

haukepetersen · 2014-07-03T19:08:21Z

Regarding the licenses, there are two files, (i) stm32f4xx.h in cpu/include and (ii) system_stm32f4xx.c.
for (i) is a pure header file, and if I remember correctly, header files are not copyrightable?!
for (ii) the file doesn't really have a copyright notice, as its generated code from some excel sheet

OpenCM3 doesn't really supply an alternative, as they are using their complete own scheme for header files. This I would's like to use, as the vendor header files we use all follow the same scheme, which makes it nice when switching between ST, Frescale, NXP etc...

I talked further to @StefanPfeiffer, that on the long run it would make sense for us to re-implement the system_xx.c our self, as this could bring us some more opportunities towards variable clocks.

So in the end, for my opinion we should be fine with these two files, or is anyone strongly disagreeing?

LudwigKnuepfer · 2014-07-04T07:23:38Z

Regarding the system_stm32f4xx.c:
In general, if a file does not have a license, you are not allowed to do anything with it (as that is what the license does)... not sure how that applies to generated content. In any case it has all those comments that are probably not generated.
Can we generate our own version?

LudwigKnuepfer · 2014-07-04T07:25:26Z

I'd opt for implementing our own version.. one that abides to our coding conventions ;-)

OlegHahm · 2014-07-04T08:45:49Z

In general, if a file does not have a license, you are not allowed to do anything with it

At least in Germany.

haukepetersen · 2014-07-04T09:03:11Z

Ok, so I guess re-implementing it is. I just looked into the CubeMX configuration-generation tool from ST (some windows-based f***), and this is generating code with this license:

  ******************************************************************************
  *
  * COPYRIGHT(c) 2014 STMicroelectronics
  *
  * Redistribution and use in source and binary forms, with or without modification,
  * are permitted provided that the following conditions are met:
  *   1. Redistributions of source code must retain the above copyright notice,
  *      this list of conditions and the following disclaimer.
  *   2. Redistributions in binary form must reproduce the above copyright notice,
  *      this list of conditions and the following disclaimer in the documentation
  *      and/or other materials provided with the distribution.
  *   3. Neither the name of STMicroelectronics nor the names of its contributors
  *      may be used to endorse or promote products derived from this software
  *      without specific prior written permission.
  *
  * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
  * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
  * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
  * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
  * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
  * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
  * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
  * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *
  ******************************************************************************

LudwigKnuepfer · 2014-07-04T10:43:49Z

That's a regular 3 clause BSD license if I didn't overlook something.. it's already approved by our license checker =)

thomaseichinger · 2014-07-04T10:57:50Z

I implemented a version compliant to our coding conventions for #1363 in system_stm32f1.c

LudwigKnuepfer · 2014-07-09T14:45:13Z

Rebase on master and throw out the license commit (was already merged via #1396)

haukepetersen · 2014-07-09T19:20:32Z

rebased. The licensing issue with the start-up code is on progress, will update as soon as this is ready.

haukepetersen · 2014-07-10T07:55:12Z

adjusted PR for the the merged #856

mehlis · 2014-07-10T11:50:11Z

@haukepetersen the BSD is absolutely no problem :) great!

Kijewski · 2014-07-10T12:01:39Z

boards/stm32f4discovery/Makefile

I'd throw out the comments and the empty DIRS variable

why throw out comments, they dont hurt... The DIRS I can throw out.

haukepetersen · 2014-07-11T08:53:24Z

rebased and fixed error introduced from #1398

haukepetersen · 2014-07-11T09:00:51Z

addressed comment from @Kijewski

haukepetersen · 2014-07-15T19:26:56Z

Here we go, I implemented the clock-setup code myself, this should take care of the license issues. Also did the usual squashing/rebasing - this PR should now be ready to merge?!

OlegHahm · 2014-07-16T08:06:10Z

Again here: Who's equipped with the right hardware and willing to test?

OlegHahm · 2014-07-16T15:07:23Z

ACK - works with Launchpad ARM embedded toolchain.

OlegHahm · 2014-07-16T15:07:57Z

Wanna squash something?

haukepetersen · 2014-07-16T15:14:41Z

yapp, squash on the way

haukepetersen · 2014-07-16T16:24:50Z

and go!

board: Initial import of stm32f4discovery board

haukepetersen added the WIP label May 16, 2014

haukepetersen added this to the Release NEXT MAJOR milestone May 16, 2014

OlegHahm added arm labels May 16, 2014

OlegHahm assigned thomaseichinger May 16, 2014

haukepetersen mentioned this pull request Jun 3, 2014

board/cpu: Import of STM32F3discovery (Cortex-M4) port #932

Closed

Kijewski reviewed Jun 10, 2014
View reviewed changes

haukepetersen mentioned this pull request Jun 11, 2014

cortex-m port #413

Closed

haukepetersen changed the title ~~board: Initial import of stm32f4discovery board (WIP)~~ board: Initial import of stm32f4discovery board Jul 3, 2014

haukepetersen mentioned this pull request Jul 3, 2014

FPU support for the Cortex-M4F family #1366

Closed

Kijewski reviewed Jul 10, 2014
View reviewed changes

haukepetersen added 4 commits July 16, 2014 17:20

board: Initial import of stm32f4discovery

99ecd48

cpu: Initial import of stm32f4

2fa9b4d

cpu: Initial import of cortex-m4_common

29e70c1

test/examples: blacklisted stm32f4discovery

a49fc06

haukepetersen added a commit that referenced this pull request Jul 16, 2014

Merge pull request #1191 from haukepetersen/board_stm32f4discovery

86eb5c4

board: Initial import of stm32f4discovery board

haukepetersen merged commit 86eb5c4 into RIOT-OS:master Jul 16, 2014

haukepetersen deleted the board_stm32f4discovery branch July 16, 2014 16:24

Conversation

haukepetersen commented May 16, 2014

Uh oh!

Kijewski commented May 16, 2014

Uh oh!

haukepetersen commented May 16, 2014

Uh oh!

mehlis commented May 30, 2014

Uh oh!

haukepetersen commented Jun 2, 2014

Uh oh!

haukepetersen commented Jun 5, 2014

Uh oh!

LudwigKnuepfer commented Jun 6, 2014

Uh oh!

haukepetersen commented Jun 6, 2014

Uh oh!

LudwigKnuepfer commented Jun 6, 2014

Uh oh!

haukepetersen commented Jun 10, 2014

Uh oh!

Kijewski Jun 10, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen Jun 10, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Jun 24, 2014

Uh oh!

LudwigKnuepfer commented Jun 25, 2014

Uh oh!

LudwigKnuepfer commented Jun 25, 2014

Uh oh!

haukepetersen commented Jun 25, 2014

Uh oh!

LudwigKnuepfer commented Jun 25, 2014

Uh oh!

haukepetersen commented Jun 26, 2014

Uh oh!

LudwigKnuepfer commented Jun 27, 2014

Uh oh!

haukepetersen commented Jun 30, 2014

Uh oh!

haukepetersen commented Jul 3, 2014

Uh oh!

haukepetersen commented Jul 3, 2014

Uh oh!

LudwigKnuepfer commented Jul 4, 2014

Uh oh!

LudwigKnuepfer commented Jul 4, 2014

Uh oh!

OlegHahm commented Jul 4, 2014

Uh oh!

haukepetersen commented Jul 4, 2014

Uh oh!

LudwigKnuepfer commented Jul 4, 2014

Uh oh!

thomaseichinger commented Jul 4, 2014

Uh oh!

LudwigKnuepfer commented Jul 9, 2014

Uh oh!

haukepetersen commented Jul 9, 2014

Uh oh!

haukepetersen commented Jul 10, 2014

Uh oh!

mehlis commented Jul 10, 2014

Uh oh!

Kijewski Jul 10, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen Jul 11, 2014

Choose a reason for hiding this comment

Uh oh!

haukepetersen commented Jul 11, 2014

Uh oh!

haukepetersen commented Jul 11, 2014

Uh oh!

haukepetersen commented Jul 15, 2014

Uh oh!

OlegHahm commented Jul 16, 2014