Skip to content

board: cpu: initial import of iot-lab_M3#1363

Merged
thomaseichinger merged 9 commits intoRIOT-OS:masterfrom
thomaseichinger:thirdparty_boards_import
Aug 21, 2014
Merged

board: cpu: initial import of iot-lab_M3#1363
thomaseichinger merged 9 commits intoRIOT-OS:masterfrom
thomaseichinger:thirdparty_boards_import

Conversation

@thomaseichinger
Copy link
Copy Markdown
Member

@thomaseichinger thomaseichinger commented Jul 3, 2014

This is an initial port for the iot-lab_M3 board and stm32f1 cpu.
This is a rewrite so it is implemented without the use of ST's peripheral library.

Done:

  • context switching
  • timers
  • gpio
  • uart
  • stdio
  • spi
  • at86rf231

OlegHahm
OlegHahm reviewed Jul 3, 2014
View reviewed changes
boards/iot-lab_M3/Makefile.dep Outdated
Copy link
Copy Markdown
Member

@OlegHahm OlegHahm Jul 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation level is too deep.

@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Jul 3, 2014

addressed @OlegHahm's comments and fixed some warnings.

haukepetersen
haukepetersen reviewed Jul 3, 2014
View reviewed changes
boards/iot-lab_M3/Makefile.include Outdated
Copy link
Copy Markdown
Contributor

@haukepetersen haukepetersen Jul 3, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the -flto (see #1365) for avoiding trouble with arch-linux arm-embedded toolchains

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Aug 20, 2014

The file still is in an odd charset: thomaseichinger@104a5c7

@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 20, 2014

updated removing unnecessary files and fix encoding as pointed out by @LudwigOrtmann

@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from 5929474 to b38696f Compare August 20, 2014 09:09
@haukepetersen
Copy link
Copy Markdown
Contributor

haukepetersen commented Aug 20, 2014

Looks good to me, even that I do not have a board to test, but as you used this code in Toronto I trust you on this. Could you just open two issues:

  1. finish implementing SPI driver
  2. finish porting the radio driver to the low-level driver interface

ACK when squashed and issued are opened.

@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 21, 2014

updated:

  • finished porting radio driver to GPIO low-level interface
  • use BSRR and BRR registers for setting values of GPIO pins to improve performance

@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from faec76c to cd3e149 Compare August 21, 2014 10:35
@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 21, 2014

@haukepetersen squashed and issues #1588 and #1589 created

@OlegHahm do you want to do any final testing?
@LudwigOrtmann do you see any remaining encoding problems?
@ALL any final objections?

@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from cd3e149 to d2ff830 Compare August 21, 2014 13:35
@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from d2ff830 to d3bf089 Compare August 21, 2014 14:35
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 21, 2014

There seems to be still a couple of problems with radio, but otherwise: http://www.youtube.com/watch?feature=player_detailpage&v=rMdC45S79uQ#t=67

@LudwigKnuepfer
Copy link
Copy Markdown
Member

LudwigKnuepfer commented Aug 21, 2014

ACK

@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from fc138a8 to e6b6af4 Compare August 21, 2014 15:04
@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 21, 2014

waiting for #1592

@thomaseichinger thomaseichinger force-pushed the thirdparty_boards_import branch from e6b6af4 to 0e79a01 Compare August 21, 2014 15:54
@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 21, 2014

waiting for travis one last time

@thomaseichinger
Copy link
Copy Markdown
Member Author

thomaseichinger commented Aug 21, 2014

Travis is happy, let's go for it.

thomaseichinger added a commit that referenced this pull request Aug 21, 2014
@thomaseichinger
Merge pull request #1363 from thomaseichinger/thirdparty_boards_import
0ea5f94 
board: cpu: initial import of iot-lab_M3
@thomaseichinger thomaseichinger merged commit 0ea5f94 into RIOT-OS:master Aug 21, 2014
@thomaseichinger thomaseichinger deleted the thirdparty_boards_import branch August 21, 2014 16:47
@OlegHahm
Copy link
Copy Markdown
Member

OlegHahm commented Aug 21, 2014

Hooray! \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@haukepetersen haukepetersen

Labels

Discussion: RFC The issue/PR is used as a discussion starting point about the item of the issue/PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@thomaseichinger @haukepetersen @OlegHahm @dangnhat @LudwigKnuepfer @Kijewski @miri64