Rename include/extractor/name_table.hpp to string_table.hpp#7417
Merged
DennisOSRM merged 3 commits intoclaude/rename-name-table-and-propertiesfrom Mar 20, 2026
Merged
Conversation
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/00dddfd9-86cd-4b55-8b30-a686e16cbcfb
Copilot
AI
changed the title
[WIP] Rename extractor name_table.hpp to string_table.hpp
Rename Mar 20, 2026
include/extractor/name_table.hpp to string_table.hpp
DennisOSRM
added a commit
that referenced
this pull request
Mar 22, 2026
* Initial plan * Rename NameTable to PreDatafacadeStringViewer and name_id to string_view_id Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Simplify naming: rename PreDatafacadeStringViewer to StringTable Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix clang-format for node_based_edge.hpp Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> * Fix compilation errors after name_id→string_view_id and NameTableImpl→StringTableImpl rename - Replace detail::NameTableImpl with detail::StringTableImpl in serialization.hpp - Replace NodeBasedEdgeAnnotation::name_id with string_view_id across all affected files: node_data_container.hpp, graph_compressor.cpp, extraction_containers.cpp, node_based_graph_factory.cpp, node_based_graph_walker.cpp, mergable_road_detector.cpp, intersection_handler.cpp/.hpp, motorway_handler.cpp, sliproad_handler.cpp, turn_handler.cpp, roundabout_handler.cpp, segregated_intersection_classification.cpp, is_through_street.hpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Apply clang-format line wrapping to string_view_id call sites Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix unit test compilation * Rename `include/extractor/name_table.hpp` to `string_table.hpp` (#7417) * Fix formatting --------- Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com> Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Co-authored-by: Dennis Luxen <info@project-osrm.org> Co-authored-by: Dennis Luxen <ich@dennisluxen.de> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file
include/extractor/name_table.hppalready contained theStringTable/StringTableImplimplementation (including aSTRING_TABLEinclude guard), but the filename still saidname_table. This renames the file to match its actual contents.Changes
include/extractor/string_table.hpp— theStringTableimplementation now lives hereinclude/extractor/name_table.hppreplaced with a deprecated#include "extractor/string_table.hpp"wrapper for backward compatibility#include "extractor/name_table.hpp"references updated acrossinclude/extractor/,include/guidance/,include/storage/,include/util/guidance/, andsrc/unit_tests/extractor/name_table.cpp→string_table.cpp; updated suite/case names, helper function (PrapareNameTableData→PrepareStringTableData, also fixes a pre-existing typo), and type references (NameTable→StringTable)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.