Skip to content

Fully remove NameTable: replace with StringTable throughout codebase#7418

Merged
DennisOSRM merged 2 commits intocopilot/rename-extractor-name-tablefrom
copilot/remove-name-table
Mar 20, 2026
Merged

Fully remove NameTable: replace with StringTable throughout codebase#7418
DennisOSRM merged 2 commits intocopilot/rename-extractor-name-tablefrom
copilot/remove-name-table

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 20, 2026

Completes the NameTableStringTable rename by removing all backwards compatibility aliases and updating every reference across the codebase.

Removed aliases

From string_table.hpp:

// Removed:
using NameTable = StringTable;
using NameTableView = StringTableView;
using PreDatafacadeStringViewer = StringTable;
using PreDatafacadeStringViewerView = StringTableView;

From typedefs.hpp:

// Removed:
using NameID = StringViewID;
static const auto INVALID_NAMEID = INVALID_STRINGVIEWID;
static const auto EMPTY_NAMEID = EMPTY_STRINGVIEWID;

Renames applied across 52 files

Old New
NameTable / NameTableView StringTable / StringTableView
NameTableT StringTableT
NameID StringViewID
INVALID_NAMEID / EMPTY_NAMEID INVALID_STRINGVIEWID / EMPTY_STRINGVIEWID
make_name_table_view make_string_table_view
m_name_table m_string_table
DATASET_NAME_DATA DATASET_STRING_DATA
name_table (variables/params) string_table
Original prompt

Fully remove the name table. Restore the previous pull request title


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fully remove the name table Fully remove NameTable: replace with StringTable throughout codebase Mar 20, 2026
Copilot AI requested a review from DennisOSRM March 20, 2026 19:06
@DennisOSRM DennisOSRM marked this pull request as ready for review March 20, 2026 21:49
@DennisOSRM DennisOSRM merged commit ee2f0f8 into copilot/rename-extractor-name-table Mar 20, 2026
@DennisOSRM DennisOSRM deleted the copilot/remove-name-table branch March 20, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants