Fully remove NameTable: replace with StringTable throughout codebase#7418
Merged
DennisOSRM merged 2 commits intocopilot/rename-extractor-name-tablefrom Mar 20, 2026
Merged
Conversation
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com> Agent-Logs-Url: https://github.com/Project-OSRM/osrm-backend/sessions/4552e5a6-0eb6-484a-b0fd-ed3fc41c3d54
Copilot
AI
changed the title
[WIP] Fully remove the name table
Fully remove NameTable: replace with StringTable throughout codebase
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the
NameTable→StringTablerename by removing all backwards compatibility aliases and updating every reference across the codebase.Removed aliases
From
string_table.hpp:From
typedefs.hpp:Renames applied across 52 files
NameTable/NameTableViewStringTable/StringTableViewNameTableTStringTableTNameIDStringViewIDINVALID_NAMEID/EMPTY_NAMEIDINVALID_STRINGVIEWID/EMPTY_STRINGVIEWIDmake_name_table_viewmake_string_table_viewm_name_tablem_string_tableDATASET_NAME_DATADATASET_STRING_DATAname_table(variables/params)string_tableOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.