Rename NameTable→StringTable and name_id→string_view_id#7406
Merged
DennisOSRM merged 11 commits intomasterfrom Mar 22, 2026
Merged
Rename NameTable→StringTable and name_id→string_view_id#7406DennisOSRM merged 11 commits intomasterfrom
DennisOSRM merged 11 commits intomasterfrom
Conversation
…iew_id Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
Co-authored-by: DennisOSRM <1067895+DennisOSRM@users.noreply.github.com>
…table-and-properties
…→StringTableImpl rename - Replace detail::NameTableImpl with detail::StringTableImpl in serialization.hpp - Replace NodeBasedEdgeAnnotation::name_id with string_view_id across all affected files: node_data_container.hpp, graph_compressor.cpp, extraction_containers.cpp, node_based_graph_factory.cpp, node_based_graph_walker.cpp, mergable_road_detector.cpp, intersection_handler.cpp/.hpp, motorway_handler.cpp, sliproad_handler.cpp, turn_handler.cpp, roundabout_handler.cpp, segregated_intersection_classification.cpp, is_through_street.hpp Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the semantic confusion described in #4709: the
NameTableclass stores much more than just names (refs, exit numbers, destinations, pronunciations), andname_idchecks likedata.name_id != EMPTY_NAMEIDwere misleading.Changes
Core renames
detail::NameTableImpl→detail::StringTableImplininclude/extractor/name_table.hppusing NameTable→using StringTable,NameTableView→StringTableViewNodeBasedEdgeAnnotation::name_id→NodeBasedEdgeAnnotation::string_view_idNameID→StringViewID,EMPTY_NAMEID→EMPTY_STRINGVIEWID,INVALID_NAMEID→INVALID_STRINGVIEWIDBackwards compatibility
Old names (
NameTable,NameID,EMPTY_NAMEID, etc.) are kept as deprecated aliases so downstream code continues to compile.All call sites updated
All 15 files that accessed
NodeBasedEdgeAnnotation::name_idare updated to usestring_view_id:include/extractor/node_data_container.hpp,serialization.hppinclude/guidance/intersection_handler.hpp,is_through_street.hppsrc/extractor/:graph_compressor,extraction_containers,node_based_graph_factory,mergable_road_detector,node_based_graph_walkersrc/guidance/:intersection_handler,motorway_handler,sliproad_handler,turn_handler,roundabout_handler,segregated_intersection_classificationFixes #4709