Overview of Entire NIOAsyncRuntime Implementation#2
Closed
scottmarchant wants to merge 11 commits intomainfrom
Closed
Overview of Entire NIOAsyncRuntime Implementation#2scottmarchant wants to merge 11 commits intomainfrom
scottmarchant wants to merge 11 commits intomainfrom
Conversation
…nc-runtime and target/library name NIOAsyncRuntime
…ng AsyncEventLoop.
…uch easier to run.
… Swift Concurrency and the AsyncEventLoopExecutor. Forms a key foundation for several vapor repositories to use NIO without using NIOPosix. This enables a large amount of wasm compilation for packages that currently consume NIOPosix.
…st majority of these tests were ported from NIOPosix tests for SelectableEventLoop, which AsyncEventLoop replaces.
…he vast majority of these tests were ported from NIOPosix tests for its own MultiThreadedEventLoopGroup. These tests ensure basic feature parity between the two different implementations.
…ensure feature parity.
6be4de6 to
24a2d65
Compare
This was referenced Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
| @@ -0,0 +1,44 @@ | |||
| name: Pull request | |||
Collaborator
Author
There was a problem hiding this comment.
Don't merge this PR. It is meant to show all changes together
scottmarchant
commented
Dec 2, 2025
| @@ -0,0 +1,44 @@ | |||
| name: Pull request | |||
|
|
|||
| on: | |||
Collaborator
Author
There was a problem hiding this comment.
Please don't review this PR. Review the small PR's. This larger PR is just an aid in case seeing everything at once is helpful.
Collaborator
Author
|
Done with this overview PR. All included changes have been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR shows all changes planned for the initial release of NIOAsyncRuntime, which is an re-implementation of the portions of NIOPosix used by the PassiveLogic dependency tree, using Swift Concurrency.
Below is a list of all changes included in the initial implementation of NIOAsyncRuntime.
CI and testing setup:
Implementations:
Tests:
Note that these tests are almost direct ports of the tests in NIOPosix for the corresponding functionality.
PR Dependencies:
Tests performed
In addition to the unit tests implemented, the changes have also been tested in real-world application by running
GraphManagerandQuantumProjectManagerin the browser to migrate database schemas, connect with our server, and pull data from a real user account.