feat: Implement AsyncEventLoopExecutor to lay foundation#11
Merged
scottmarchant merged 1 commit intomainfrom Dec 3, 2025
Merged
feat: Implement AsyncEventLoopExecutor to lay foundation#11scottmarchant merged 1 commit intomainfrom
scottmarchant merged 1 commit intomainfrom
Conversation
2b0a755 to
2eca931
Compare
scottmarchant
commented
Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
scottmarchant
commented
Dec 2, 2025
Collaborator
|
Did this start as copy-pasta from a NIO implementation and then get pruned down to rip out unavailable dependencies? |
scottmarchant
commented
Dec 2, 2025
CrownedPhoenix
approved these changes
Dec 2, 2025
68 tasks
krodak
approved these changes
Dec 3, 2025
Collaborator
Author
@CrownedPhoenix No, this started out as a new implementation. It actually started out really simple, just had the actor serial guard. But grew rather complex with all the different edge cases required for unit test parity. At some point, I wouldn't mind revisiting it and trying to split apart some of the responsibilities. It is admittedly pretty hard to follow right now. |
…ng AsyncEventLoop.
2eca931 to
a0368a0
Compare
karloscarweber
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement AsyncEventLoopExecutor that forms the basis of operations for NIOAsyncRuntime
Details
Usage Examples
Testing Performed
Tests coverage provided in tests ported from NIOPosix: #6.
The changes have also been tested in real-world application by running
GraphManagerandQuantumProjectManagerin the browser to migrate database schemas, connect with our server, and pull data from a real user account.PR Dependencies
#3
Overview of all changes
All planned changes can be viewed together in #2