Skip to content

test: Add MultiThreadedEventLoopGroup tests#7

Merged
scottmarchant merged 1 commit intomainfrom
test/testMultiThreadedEventLoopGroup
Dec 5, 2025
Merged

test: Add MultiThreadedEventLoopGroup tests#7
scottmarchant merged 1 commit intomainfrom
test/testMultiThreadedEventLoopGroup

Conversation

@scottmarchant
Copy link
Copy Markdown
Collaborator

@scottmarchant scottmarchant commented Dec 2, 2025

Summary

Ported tests from NIOPosix that test the implementation of MultiThreadedEventLoopGroup in NIOAsyncRuntime.

ℹ️ Because these tests are ported, we prefer to keep them in their current format and implementation to make comparison with tests in NIOPosix easier down the road. At some point, if NIOAsyncRuntime is ever merged into swift-nio, the tests may be consolidated.

Details

  • c80bbbc test: Add tests for MultiThreadedEventLoopGroup in NIOAsyncRuntime. The vast majority of these tests were ported from NIOPosix tests for its own MultiThreadedEventLoopGroup. These tests ensure basic feature parity between the two different implementations.

PR Dependencies

#5

Overview of all changes

All planned changes can be viewed together in #2

@scottmarchant scottmarchant changed the title Add MultiThreadedEventLoopGroup tests test: Add MultiThreadedEventLoopGroup tests Dec 2, 2025
@scottmarchant scottmarchant force-pushed the test/testMultiThreadedEventLoopGroup branch from c80bbbc to aa0f489 Compare December 2, 2025 18:25
@scottmarchant scottmarchant self-assigned this Dec 2, 2025
@scottmarchant scottmarchant marked this pull request as ready for review December 2, 2025 20:20
@scottmarchant scottmarchant force-pushed the test/testMultiThreadedEventLoopGroup branch from aa0f489 to 170cacf Compare December 3, 2025 20:54
Base automatically changed from chore/addTestUtils to main December 5, 2025 00:34
…he vast majority of these tests were ported from NIOPosix tests for its own MultiThreadedEventLoopGroup. These tests ensure basic feature parity between the two different implementations.
@scottmarchant scottmarchant force-pushed the test/testMultiThreadedEventLoopGroup branch from 170cacf to 769a6cd Compare December 5, 2025 01:04
@scottmarchant scottmarchant merged commit 864dea2 into main Dec 5, 2025
23 checks passed
@scottmarchant scottmarchant deleted the test/testMultiThreadedEventLoopGroup branch December 5, 2025 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants