Merged
Conversation
This was referenced Dec 2, 2025
2ad8fc4 to
100dd09
Compare
b48e954 to
19e9b79
Compare
68 tasks
krodak
approved these changes
Dec 3, 2025
100dd09 to
28b5f04
Compare
3d88303 to
f1e0944
Compare
karloscarweber
approved these changes
Dec 3, 2025
28b5f04 to
c696508
Compare
f1e0944 to
e21b5f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ported tests from NIOPosix that test the implementation of
NIOThreadPoolin NIOAsyncRuntime.ℹ️ Because these tests are ported, we prefer to keep them in their current format and implementation to make comparison with tests in NIOPosix easier down the road. At some point, if NIOAsyncRuntime is ever merged into swift-nio, the tests may be consolidated.
Details
PR Dependencies
#8
Overview of all changes
All planned changes can be viewed together in #2