Fix/0.12 NEW content processors#422
Merged
moustachu merged 4 commits into0.12-stablefrom Jan 18, 2019
Merged
Conversation
- only replace link when url contains "proposals" path - prevent switching between components with same item id
- add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ResultPresenter`
- add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ProjectPresenter`
moustachu
added a commit
to OpenSourcePolitics/osp-app
that referenced
this pull request
Jan 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Detected with #421 : Component object path (like Results or Projects) are interpreted as Proposals when adding a link in a comment.
This PR intend to :
/proposals/in their pathAccountabilityResultsBudgetsProjects/proposals/)📌 Related Issues
📋 Subtasks
CHANGELOGentry