Skip to content

0.12 - Exports fixes#420

Merged
moustachu merged 7 commits into0.12-stablefrom
fix/0.12-i18n-exports
Jan 18, 2019
Merged

0.12 - Exports fixes#420
moustachu merged 7 commits into0.12-stablefrom
fix/0.12-i18n-exports

Conversation

@moustachu
Copy link
Copy Markdown
Member

@moustachu moustachu commented Jan 17, 2019

🐛 #417 : fix exports translatable_attr when first line is empty

🎩 What? Why?

Mainly aim to fix #417, but will provides a few fixes for exports for 0.12-stable ++

  • add empty_translatable helper to provide blank values
  • fix Decidim::Proposals::ProposalSerializer
  • fix Decidim::Comments::CommentSerializer
  • fix Decidim::Accountability::ResultSerializer
  • fix Decidim::Surveys::SurveyUserAnswersSerializer
  • add created_at to survey answer export
  • TODO : need specific tests on headers

📌 Related Issues

📋 Subtasks

  • Add documentation regarding the feature
  • Add tests

- add `empty_translatable` helper to provide blank values
- fix `Decidim::Proposals::ProposalSerializer`
- fix `Decidim::Comments::CommentSerializer`
- fix `Decidim::Accountability::ResultSerializer`
- TODO : need specific tests on headers
@moustachu moustachu added the 0.12-stable Version label Jan 17, 2019
@moustachu moustachu self-assigned this Jan 17, 2019
@moustachu moustachu requested a review from lu-hamani January 17, 2019 15:34
@ghost ghost added the needs-review label Jan 17, 2019
@moustachu moustachu merged commit 33cf249 into 0.12-stable Jan 18, 2019
@ghost ghost removed the needs-review label Jan 18, 2019
moustachu added a commit to OpenSourcePolitics/osp-app that referenced this pull request Jan 18, 2019
@lu-hamani lu-hamani mentioned this pull request Jan 21, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants