Conversation
Member
Author
|
I'll get some benchmark numbers in a bit. |
martinrrm
approved these changes
Apr 2, 2026
Nigusu-Allehu
approved these changes
Apr 2, 2026
Member
Author
|
Running it against client dgspecs, it's honestly not even noticeable.
|
This was referenced Apr 3, 2026
kartheekp-ms
pushed a commit
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#14840
Description
In #7246, I realized Test-NetCoreVSandMSBuildNoOp, which is the main way we check for no-op equivalency in VS vs CLI is not running.
It was disabled in because of NuGet/Home#13003 in #5469 but we never enabled it back.
That was
Nov 10, 2023.Unfortunately there's been many changes in this space, including a new algorithm that have basically broken this test.
This has a massive impact, since a huge number of projects have CPM enabled and everyone .NET and above has pruning data.
Some of the changes that may have regressed it:
Related: NuGet/Home#11231
This has a perf cost, but no-op is cheaper than the actual cost of doing a real restore.
PR Checklist